emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Timothy <tecosaur@gmail.com>
To: Nico Sonack <nsonack@outlook.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Customizify org-babel-fortran-compiler
Date: Thu, 01 Jul 2021 22:40:30 +0800	[thread overview]
Message-ID: <878s2qhzc1.fsf@gmail.com> (raw)
In-Reply-To: <AM9PR01MB73931207A7C9B7C7857BD414AC039@AM9PR01MB7393.eurprd01.prod.exchangelabs.com>

Hi Nico,

Thanks for sending in the patch. Seeing it pointed out, this seems like
a pretty obvious omission. This looks like it should be pretty easy to
merge :)

Four minor niggles with your commit message:
+ Since `defvar' and `defcustom' are elisp symbols, they should be
  quoted as such.
+ It's probably better to avoid shorthand like "X -> Y", and write out
  "Change X to Y" instead.
+ You have included "lisp/" in the commit subject, which isn't needed.
  Just "ob-fortran.el" or even "ob-fortran" is enough here.
+ Your commit subject goes over 50 chars, which is undesirable.

Here's what I'd recommend:

ob-fortran: Use a defcustom for fortran compiler

* lisp/ob-fortran.el (org-babel-fortran-compiler): Change `defvar' to `defcustom'
so that the fortran compiler is customizable like almost all other org-babel

This is rather minor though, I mention this mostly as a note for the
future :)


Nico Sonack <nsonack@outlook.com> writes:

> Hey there,
> I've been using org-mode for quite a while already and am pretty
> happy with it!
> Today I noticed a minor oddity, that occured when I tried to run some
> Fortran code with org-babel: it failed with the compiler not being
> found. Looking at the custom variables of the org-babel group, I was
> unable to find a compiler option for Fortran. Thus, I quickly patched
> the ob-fortran.el and turned the defvar of
> `org-babel-fortran-compiler' into a defcustom such that it is a little
> more consistent with the rest of the org-babel languages.
> The patch is attached to this mail. Please let me know if I should
> correct anything.
> Nico

  reply	other threads:[~2021-07-01 14:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 10:21 [PATCH] Customizify org-babel-fortran-compiler Nico Sonack
2021-07-01 14:40 ` Timothy [this message]
2021-07-01 21:22   ` Nicolas Goaziou
  -- strict thread matches above, loose matches on Subject: below --
2021-06-28  9:34 Nico Sonack
2021-07-01 14:45 ` Timothy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s2qhzc1.fsf@gmail.com \
    --to=tecosaur@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=nsonack@outlook.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).