emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Timothy <tecosaur@gmail.com>
Cc: Nico Sonack <nsonack@outlook.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Customizify org-babel-fortran-compiler
Date: Thu, 01 Jul 2021 23:22:14 +0200	[thread overview]
Message-ID: <87im1twwzd.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <878s2qhzc1.fsf@gmail.com> (Timothy's message of "Thu, 01 Jul 2021 22:40:30 +0800")


Timothy <tecosaur@gmail.com> writes:

> Thanks for sending in the patch. Seeing it pointed out, this seems like
> a pretty obvious omission. This looks like it should be pretty easy to
> merge :)
> Four minor niggles with your commit message:
> + Since `defvar' and `defcustom' are elisp symbols, they should be
>   quoted as such.
> + It's probably better to avoid shorthand like "X -> Y", and write out
>   "Change X to Y" instead.
> + You have included "lisp/" in the commit subject, which isn't needed.
>   Just "ob-fortran.el" or even "ob-fortran" is enough here.
> + Your commit subject goes over 50 chars, which is undesirable.
> Here's what I'd recommend:
> #+begin_example
> ob-fortran: Use a defcustom for fortran compiler
> * lisp/ob-fortran.el (org-babel-fortran-compiler): Change `defvar' to `defcustom'
> so that the fortran compiler is customizable like almost all other org-babel
> compilers.
> #+end_example
> This is rather minor though, I mention this mostly as a note for the
> future :)


I went ahead, applied the patch with your recommendation, added
a :package-version keyword, and pushed.


Nicolas Goaziou

  reply	other threads:[~2021-07-01 21:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 10:21 [PATCH] Customizify org-babel-fortran-compiler Nico Sonack
2021-07-01 14:40 ` Timothy
2021-07-01 21:22   ` Nicolas Goaziou [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-06-28  9:34 Nico Sonack
2021-07-01 14:45 ` Timothy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im1twwzd.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=nsonack@outlook.com \
    --cc=tecosaur@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).