From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aJ67ARHU3WBvTwAAgWs5BA (envelope-from ) for ; Thu, 01 Jul 2021 16:41:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sJASORDU3WBBHgAAB5/wlQ (envelope-from ) for ; Thu, 01 Jul 2021 14:41:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7898CD6C8 for ; Thu, 1 Jul 2021 16:41:20 +0200 (CEST) Received: from localhost ([::1]:46654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyxsV-0008E4-Ga for larch@yhetil.org; Thu, 01 Jul 2021 10:41:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyxrp-0008Ds-1x for emacs-orgmode@gnu.org; Thu, 01 Jul 2021 10:40:37 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:42911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyxrn-0003xQ-Ht for emacs-orgmode@gnu.org; Thu, 01 Jul 2021 10:40:36 -0400 Received: by mail-pg1-x536.google.com with SMTP id d12so6277601pgd.9 for ; Thu, 01 Jul 2021 07:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version; bh=ZuyKyRNerllYyRPRpmsU9+Jn9TzNOwMC7U4i4LPvdyQ=; b=BWXF8Ehf16FWX5rVQ5jmL+ZU4shuIXeja5+kI/ILUruOi2InmeJCmCm+fFRCGr4fUM w/Nle8VVQ3T/WLPQs/9UD3wgS7zbPWa4ILC2tqsrCjIbsZJ9nyE25v+Lk7KD/jXIH/g2 u8djuWPpa9QMblpCCKsu7F/asEojNI2TklhxiOEEUOBuYvrlbNtgCCqzWY0ddNIhbMWy ZlSPF6DzKokK5vCm1iEzaonbvd+0DPQQD4s/DgV52GawOAtl+wny8gdonvLigwtTnsJH MgPC3J9TvgsV+O2otVIqtPOKXb1HHUXogtFAv+4q3VfaQlaqZRUjKv9Vk0mlGsnnp80n x9TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=ZuyKyRNerllYyRPRpmsU9+Jn9TzNOwMC7U4i4LPvdyQ=; b=AkUNXtRYqsQhMWlCY3OTaqCz09auBM7aHetR0o4ItVt3acw9WLCSmjlMOExTHuMpUP f8ob3X2nzBqg9InR3fiWhs0eRvC9H5Ulz++hs8MFZdDE4fSoSH5nYYCUWE8f/+CEvRv3 Ysj4cM/lsZ+yV7ZrgLWrGS7+owgwWw9vny1y799EgWYgCFJJWXYYpoquvri+eCJoFWSW QzAu9AoVxRTofTsddtISJV/aCC5/so38Hg6fSzYLJQKN21ojhLRtvY5OxQfz6dWhdljC v6mfuj8HtNIsIIyeVVxZ8VBz4rHSxYRMuDMpx5NT4HsyCDNgQY5g5Ur7R0K2MoO7ryqe mkCg== X-Gm-Message-State: AOAM5335UIFr5LmR50ADMGQ5m4CljYRYzD0cr3l+egL2+ylmk+uDfQJr lOCYyr6d8hUBDs0nBPCVf6M= X-Google-Smtp-Source: ABdhPJzdGv9I1ATg0UfHLNwuQfaQXfn0qXUYFE5RIpeQMvMGW27xrot5nxks5nQqHQHF5yI3S1DH+A== X-Received: by 2002:a63:1107:: with SMTP id g7mr31722068pgl.59.1625150434045; Thu, 01 Jul 2021 07:40:34 -0700 (PDT) Received: from localhost (180-150-91-8.b4965b.per.nbn.aussiebb.net. [180.150.91.8]) by smtp.gmail.com with ESMTPSA id u38sm84451pgm.14.2021.07.01.07.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 07:40:33 -0700 (PDT) References: User-agent: mu4e 1.4.15; emacs 28.0.50 From: Timothy To: Nico Sonack Subject: Re: [PATCH] Customizify org-babel-fortran-compiler In-reply-to: Message-ID: <878s2qhzc1.fsf@gmail.com> Date: Thu, 01 Jul 2021 22:40:30 +0800 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=tecosaur@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625150480; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZuyKyRNerllYyRPRpmsU9+Jn9TzNOwMC7U4i4LPvdyQ=; b=uqzrbp7clAtKpdwMhsHb0yXHiPkGwVOKGbvjE/Ot6XifCDrFzd8q3yGHIZ88cE9WQSz5YD LSQ1/nN8mXhUSKn4KH5lD24A1twdr0QLQR04Pz+1jsp4NmizLocLdPir3pWzvTGxza0XX8 LSfhqTjOjQjlRKE1GdNDt+U2bFaB1TTUsF8e9RyAsuJFG5m5p9tbtTpm3K0OeYo+F0Bhz4 4iWNMPczhLIzUh/ebHeuOWYcuKzhGJie0W3OQzO0uOwMgmzTLJAYNOBrLgbvdMhk4vrJ7T AIqvZN/Ocs8Mb7CBvlUSPLKmiU3NSOLj22F5BrmaKgxt9LZ0jVrau/Hl0Q+4aQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625150480; a=rsa-sha256; cv=none; b=f8I7t/PY38tQHH29iwEXe/cEPYG2YlLXICvZMlv30suR4kIfGodO88X9ONFlnBsZPH3jRT Sx/EfBLUVI1eCGmMbXn7WkuDhXBSuOeEufGGcCctpucT6GwsUBtBF/A4qCkSf4BfY1WtRt aclcE9RqB2RFNjEimEgaA6CLFgcbKE7Apf9G9gJLveIFJ28CkVH/S2cIg3dzmr8AGa1umI fAic72robrEFAHS+NJwkiKENrUosFJUub9XPEI1kFdEOB8rawB8BMAUhbO2qnORz5sm9Ca EEh8Z0u+4x/+fhS8ZQh0+/wbjZbg/zSbjNBkM/GBLduZxv5Di5ESaXqjESs71Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=BWXF8Ehf; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.12 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=BWXF8Ehf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 7898CD6C8 X-Spam-Score: -3.12 X-Migadu-Scanner: scn1.migadu.com X-TUID: aqKMzxLKX5eR Hi Nico, Thanks for sending in the patch. Seeing it pointed out, this seems like a pretty obvious omission. This looks like it should be pretty easy to merge :) Four minor niggles with your commit message: + Since `defvar' and `defcustom' are elisp symbols, they should be quoted as such. + It's probably better to avoid shorthand like "X -> Y", and write out "Change X to Y" instead. + You have included "lisp/" in the commit subject, which isn't needed. Just "ob-fortran.el" or even "ob-fortran" is enough here. + Your commit subject goes over 50 chars, which is undesirable. Here's what I'd recommend: #+begin_example ob-fortran: Use a defcustom for fortran compiler * lisp/ob-fortran.el (org-babel-fortran-compiler): Change `defvar' to `defcustom' so that the fortran compiler is customizable like almost all other org-babel compilers. #+end_example This is rather minor though, I mention this mostly as a note for the future :) -- Timothy Nico Sonack writes: > Hey there, > > I've been using org-mode for quite a while already and am pretty > happy with it! > > Today I noticed a minor oddity, that occured when I tried to run some > Fortran code with org-babel: it failed with the compiler not being > found. Looking at the custom variables of the org-babel group, I was > unable to find a compiler option for Fortran. Thus, I quickly patched > the ob-fortran.el and turned the defvar of > `org-babel-fortran-compiler' into a defcustom such that it is a little > more consistent with the rest of the org-babel languages. > > The patch is attached to this mail. Please let me know if I should > correct anything. > > Nico