From: Bernt Hansen <bernt@norang.ca>
To: Sebastien Vauban
<public-wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@plane.gmane.org>
Cc: public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org
Subject: Re: [PATCH 2/3] Honour existing restrictions when clocking in from the agenda
Date: Thu, 19 Jan 2012 13:05:37 -0500 [thread overview]
Message-ID: <877h0n600e.fsf@norang.ca> (raw)
In-Reply-To: <80hazrwv72.fsf@somewhere.org> (Sebastien Vauban's message of "Thu, 19 Jan 2012 16:47:29 +0100")
"Sebastien Vauban"
<wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:
> Hi Bernt,
>
> Bernt Hansen wrote:
>> Eeek!
>>
>> I'm not running into this (as far as I know) in my current setup but I
>> vote we just revert the clocking restriction patches. There are other
>> unresolved issues with these patches that I've seen and don't currently
>> have a fix for.
>>
>> Please revert the following commits (again). Sorry :(
>>
>> - 7a73e15 (Remove file restrictions when generating clock report data, 2012-01-09)
>> - e8f93a75 (Honour existing restrictions when visiting tasks from the agenda, 2011-12-30)
>> - c41a6f5 (Honour existing restrictions when clocking in from the agenda, 2011-12-30)
>> - a0a26cd (Honour existing restrictions when regenerating the agenda, 2011-12-30)
>
> FYI, I have the (subjective) impression that the below bug just came up a
> couple of days ago. I would say less than one calendar week. But I may be
> wrong.
Hi Seb,
These patches were created by me back in December and recently applied
by Bastien on Jan 11th so that's probably when the problem showed up. I
saw the initial report about this alignment problem on the mailing list
when my gmane access came back but I couldn't reproduce it with my setup
(using org-indent-mode, but I didn't try very hard at the time) so I
just assumed incorrectly that this was caused by later commits I hadn't
pulled yet.
The 4 patches really all go in the same topic. There are still other
problems with this series and right now I'm leaning towards dropping
them completely. There are lots of places in the agenda where things
seem to go wrong if the org file restriction is retained.
Regards,
Bernt
next prev parent reply other threads:[~2012-01-19 18:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 10:49 Honour existing restrictions if possible when visiting tasks from the agenda Bernt Hansen
2011-12-30 10:49 ` [PATCH 1/3] Honour existing restrictions when regenerating " Bernt Hansen
2011-12-30 10:49 ` [PATCH 2/3] Honour existing restrictions when clocking in from " Bernt Hansen
2012-01-19 13:43 ` Matt Lundin
2012-01-19 14:51 ` Bernt Hansen
2012-01-19 15:22 ` Bastien
2012-01-19 15:44 ` Bernt Hansen
2012-01-19 15:47 ` Sebastien Vauban
2012-01-19 16:11 ` Bastien
2012-01-19 18:05 ` Bernt Hansen [this message]
2011-12-30 10:49 ` [PATCH 3/3] Honour existing restrictions when visiting tasks " Bernt Hansen
2011-12-31 8:11 ` Honour existing restrictions if possible " Carsten Dominik
2011-12-31 14:12 ` Bernt Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877h0n600e.fsf@norang.ca \
--to=bernt@norang.ca \
--cc=public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org \
--cc=public-wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@plane.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).