emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bernt Hansen <bernt@norang.ca>
To: emacs-orgmode@gnu.org
Cc: Bernt Hansen <bernt@norang.ca>
Subject: [PATCH 2/3] Honour existing restrictions when clocking in from the agenda
Date: Fri, 30 Dec 2011 05:49:08 -0500	[thread overview]
Message-ID: <1325242149-22487-3-git-send-email-bernt@norang.ca> (raw)
In-Reply-To: <1325242149-22487-1-git-send-email-bernt@norang.ca>

* lisp/org-agenda.el (org-agenda-clock-in): Save restriction when clocking in from the agenda

Narrowed org buffers are now retained when clocking in from the agenda.
We only widen the buffer when the task to clock in is outside the existing
restriction.
---
 lisp/org-agenda.el |   17 +++++++++--------
 1 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 780794e..f240f5e 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7797,14 +7797,15 @@ The cursor may be at a date in the calendar, or in the Org agenda."
 	   newhead)
       (org-with-remote-undo (marker-buffer marker)
         (with-current-buffer (marker-buffer marker)
-	  (widen)
-	  (goto-char pos)
-	  (org-show-context 'agenda)
-	  (org-show-entry)
-	  (org-cycle-hide-drawers 'children)
-	  (org-clock-in arg)
-	  (setq newhead (org-get-heading)))
-	(org-agenda-change-all-lines newhead hdmarker)))))
+	  (save-restriction
+	    (widen)
+	    (goto-char pos)
+	    (org-show-context 'agenda)
+	    (org-show-entry)
+	    (org-cycle-hide-drawers 'children)
+	    (org-clock-in arg)
+	    (setq newhead (org-get-heading)))
+	  (org-agenda-change-all-lines newhead hdmarker))))))
 
 (defun org-agenda-clock-out ()
   "Stop the currently running clock."
-- 
1.7.8.247.g10f4e

  parent reply	other threads:[~2011-12-30 10:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-30 10:49 Honour existing restrictions if possible when visiting tasks from the agenda Bernt Hansen
2011-12-30 10:49 ` [PATCH 1/3] Honour existing restrictions when regenerating " Bernt Hansen
2011-12-30 10:49 ` Bernt Hansen [this message]
2012-01-19 13:43   ` [PATCH 2/3] Honour existing restrictions when clocking in from " Matt Lundin
2012-01-19 14:51     ` Bernt Hansen
2012-01-19 15:22       ` Bastien
2012-01-19 15:44       ` Bernt Hansen
2012-01-19 15:47       ` Sebastien Vauban
2012-01-19 16:11         ` Bastien
2012-01-19 18:05         ` Bernt Hansen
2011-12-30 10:49 ` [PATCH 3/3] Honour existing restrictions when visiting tasks " Bernt Hansen
2011-12-31  8:11 ` Honour existing restrictions if possible " Carsten Dominik
2011-12-31 14:12   ` Bernt Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325242149-22487-3-git-send-email-bernt@norang.ca \
    --to=bernt@norang.ca \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).