From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: [PATCH 2/3] Honour existing restrictions when clocking in from the agenda Date: Thu, 19 Jan 2012 13:05:37 -0500 Message-ID: <877h0n600e.fsf@norang.ca> References: <1325242149-22487-1-git-send-email-bernt@norang.ca> <1325242149-22487-3-git-send-email-bernt@norang.ca> <874nvr4xlb.fsf@fastmail.fm> <87fwfb690d.fsf@norang.ca> <80hazrwv72.fsf@somewhere.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:40309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnwN0-00053Z-2O for emacs-orgmode@gnu.org; Thu, 19 Jan 2012 13:05:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RnwMy-0001fM-Jt for emacs-orgmode@gnu.org; Thu, 19 Jan 2012 13:05:54 -0500 Received: from plane.gmane.org ([80.91.229.3]:58940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnwMy-0001f0-B8 for emacs-orgmode@gnu.org; Thu, 19 Jan 2012 13:05:52 -0500 Received: from public by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1RnwMq-00011U-Nu for emacs-orgmode@gnu.org; Thu, 19 Jan 2012 19:05:44 +0100 In-Reply-To: <80hazrwv72.fsf@somewhere.org> (Sebastien Vauban's message of "Thu, 19 Jan 2012 16:47:29 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Sebastien Vauban Cc: public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org "Sebastien Vauban" writes: > Hi Bernt, > > Bernt Hansen wrote: >> Eeek! >> >> I'm not running into this (as far as I know) in my current setup but I >> vote we just revert the clocking restriction patches. There are other >> unresolved issues with these patches that I've seen and don't currently >> have a fix for. >> >> Please revert the following commits (again). Sorry :( >> >> - 7a73e15 (Remove file restrictions when generating clock report data, 2012-01-09) >> - e8f93a75 (Honour existing restrictions when visiting tasks from the agenda, 2011-12-30) >> - c41a6f5 (Honour existing restrictions when clocking in from the agenda, 2011-12-30) >> - a0a26cd (Honour existing restrictions when regenerating the agenda, 2011-12-30) > > FYI, I have the (subjective) impression that the below bug just came up a > couple of days ago. I would say less than one calendar week. But I may be > wrong. Hi Seb, These patches were created by me back in December and recently applied by Bastien on Jan 11th so that's probably when the problem showed up. I saw the initial report about this alignment problem on the mailing list when my gmane access came back but I couldn't reproduce it with my setup (using org-indent-mode, but I didn't try very hard at the time) so I just assumed incorrectly that this was caused by later commits I hadn't pulled yet. The 4 patches really all go in the same topic. There are still other problems with this series and right now I'm leaning towards dropping them completely. There are lots of places in the agenda where things seem to go wrong if the org file restriction is retained. Regards, Bernt