* Latest Speed Keys "D" and "U" behavior
@ 2014-06-23 7:26 marcowahlsoft
2014-06-23 14:38 ` Matt Lundin
2014-06-23 14:56 ` Bastien
0 siblings, 2 replies; 4+ messages in thread
From: marcowahlsoft @ 2014-06-23 7:26 UTC (permalink / raw)
To: emacs-orgmode
Hi,
In the past speed key "D" (analog "U") on a headline moved the whole
subtree down. In the latest org-mode version the effect of speed key
"D" is to move the headline (and only just the headline) down. BTW this
change of behavior is due to a change in `org-shiftmetadown' AFAICT.
Is the user who wants the old behavior back supposed to configure
`org-speed-commands-user' with `org-metadown'?
Personal note: I used those keys a lot as I can clearly observe since
their functionality changed. And I vote for giving the speed keys "D"
and "U" back their old functionality.
Best regards, Marco
--
Marco Wahl -- Freelancer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Latest Speed Keys "D" and "U" behavior
2014-06-23 7:26 Latest Speed Keys "D" and "U" behavior marcowahlsoft
@ 2014-06-23 14:38 ` Matt Lundin
2014-06-23 14:55 ` Bastien
2014-06-23 14:56 ` Bastien
1 sibling, 1 reply; 4+ messages in thread
From: Matt Lundin @ 2014-06-23 14:38 UTC (permalink / raw)
To: marcowahlsoft; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]
marcowahlsoft@gmail.com writes:
> Hi,
>
> In the past speed key "D" (analog "U") on a headline moved the whole
> subtree down. In the latest org-mode version the effect of speed key
> "D" is to move the headline (and only just the headline) down. BTW this
> change of behavior is due to a change in `org-shiftmetadown' AFAICT.
>
> Is the user who wants the old behavior back supposed to configure
> `org-speed-commands-user' with `org-metadown'?
>
> Personal note: I used those keys a lot as I can clearly observe since
> their functionality changed. And I vote for giving the speed keys "D"
> and "U" back their old functionality.
I can confirm this bug. I consider it an undesired change since when one
is on a headline, one rarely wants to move only the headline up and
down. E.g., turning...
* TODO Headline
:LOGBOOK:
CLOCK: [2014-06-23 Mon 09:34]--[2014-06-23 Mon 09:35] => 0:01
:END:
...into...
:LOGBOOK:
* TODO Headline
CLOCK: [2014-06-23 Mon 09:34]--[2014-06-23 Mon 09:35] => 0:01
:END:
...does not make much sense. Below is a patch to fix it.
Best,
Matt
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-speedkeys-to-move-subtrees-up-and-down.patch --]
[-- Type: text/x-diff, Size: 1162 bytes --]
From faf34bdedcae517e68c50ae9a77ee8086588dfe3 Mon Sep 17 00:00:00 2001
From: Matt Lundin <mdl@imapmail.org>
Date: Mon, 23 Jun 2014 09:17:54 -0500
Subject: [PATCH] Fix speedkeys to move subtrees up and down
* lisp/org.el: (org-speed-commands-default) Org speed keys were not
updated to reflect the recent changes to org-shiftmetaup and
org-shiftmetadown. As a result the default bindings for speedkeys
"U" and "D" were destructive, since they moved only single
lines. Binding them to org-metaup and org-metadown fixes the
problem.
Thanks to Marco Wahl for reporting the problem:
http://permalink.gmane.org/gmane.emacs.orgmode/87873
---
lisp/org.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index c82fd06..2b57fc0 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -19523,8 +19523,8 @@ boundaries."
("s" . org-narrow-to-subtree)
("=" . org-columns)
("Outline Structure Editing")
- ("U" . org-shiftmetaup)
- ("D" . org-shiftmetadown)
+ ("U" . org-metaup)
+ ("D" . org-metadown)
("r" . org-metaright)
("l" . org-metaleft)
("R" . org-shiftmetaright)
--
2.0.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: Latest Speed Keys "D" and "U" behavior
2014-06-23 14:38 ` Matt Lundin
@ 2014-06-23 14:55 ` Bastien
0 siblings, 0 replies; 4+ messages in thread
From: Bastien @ 2014-06-23 14:55 UTC (permalink / raw)
To: Matt Lundin; +Cc: marcowahlsoft, emacs-orgmode
Hi Matt,
Matt Lundin <mdl@imapmail.org> writes:
> I can confirm this bug.
Applied in master, with a slightly modified changelog, thanks
--
Bastien
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Latest Speed Keys "D" and "U" behavior
2014-06-23 7:26 Latest Speed Keys "D" and "U" behavior marcowahlsoft
2014-06-23 14:38 ` Matt Lundin
@ 2014-06-23 14:56 ` Bastien
1 sibling, 0 replies; 4+ messages in thread
From: Bastien @ 2014-06-23 14:56 UTC (permalink / raw)
To: marcowahlsoft; +Cc: emacs-orgmode
Hi Marco,
marcowahlsoft@gmail.com writes:
> Is the user who wants the old behavior back supposed to configure
> `org-speed-commands-user' with `org-metadown'?
Nope -- reporting weird new behavior like you did will do :)
Thanks for this,
--
Bastien
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-23 14:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-23 7:26 Latest Speed Keys "D" and "U" behavior marcowahlsoft
2014-06-23 14:38 ` Matt Lundin
2014-06-23 14:55 ` Bastien
2014-06-23 14:56 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).