emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Oleh Krehel <ohwoeowho@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Unclear org-icompleting-read interface
Date: Thu, 25 Jun 2015 15:51:50 +0200	[thread overview]
Message-ID: <877fqryjyh.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87vbecudww.fsf@gmail.com> (Oleh Krehel's message of "Thu, 25 Jun 2015 15:15:59 +0200")

Hello,

Oleh Krehel <ohwoeowho@gmail.com> writes:

> The current `org-icompleting-read' is defined as taking only `&rest
> args', which can be as many as 8, all of them without a name.
>
> I propose to update the definition to:
>
>     (cl-defun org-icompleting-read (prompt collection
>                                     &key predicate require-match
>                                       initial-input hist def inherit-input-method)
>       ;; ...
>       )

I'd rather not use cl-defun in code base, which is slightly more
difficult to understand, and hardly unavoidable. Moreover,
`org-icompleting-read' is not harder to read as `completing-read'
anyway.

> This change would make the calls to `org-icompleting-read' much easier
> to read.

While we're at it, I suggest instead to make `org-icompleting-read' an
obsolete alias for `completing-read' in Org 8.4.
`partial-completing-mode' is obsolete since Emacs 24.1.


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2015-06-25 13:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 13:15 Unclear org-icompleting-read interface Oleh Krehel
2015-06-25 13:51 ` Nicolas Goaziou [this message]
2015-06-25 14:23   ` Oleh Krehel
2015-06-25 14:36   ` Rasmus
2015-06-25 16:30     ` Nicolas Goaziou
2015-06-25 16:39       ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877fqryjyh.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=ohwoeowho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).