From: Rasmus <rasmus@gmx.us>
To: emacs-orgmode@gnu.org
Subject: Re: Unclear org-icompleting-read interface
Date: Thu, 25 Jun 2015 16:36:11 +0200 [thread overview]
Message-ID: <87twtvlusk.fsf@gmx.us> (raw)
In-Reply-To: 877fqryjyh.fsf@nicolasgoaziou.fr
Hi,
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Oleh Krehel <ohwoeowho@gmail.com> writes:
>
>> The current `org-icompleting-read' is defined as taking only `&rest
>> args', which can be as many as 8, all of them without a name.
>>
>> I propose to update the definition to:
>>
>> (cl-defun org-icompleting-read (prompt collection
>> &key predicate require-match
>> initial-input hist def inherit-input-method)
>> ;; ...
>> )
>
> I'd rather not use cl-defun in code base, which is slightly more
> difficult to understand, and hardly unavoidable. Moreover,
> `org-icompleting-read' is not harder to read as `completing-read'
> anyway.
I agree. It's confusing how the docstring and the λ is written, but it's
just a "front-end" for completing-read. A reference to completing-read
should be added to the docstring.
>> This change would make the calls to `org-icompleting-read' much easier
>> to read.
>
> While we're at it, I suggest instead to make `org-icompleting-read' an
> obsolete alias for `completing-read' in Org 8.4.
> `partial-completing-mode' is obsolete since Emacs 24.1.
That was my "feeling" about org-icompleting-read as well last time I
looked at it (also a message by Oleh). For org 8.4 we can also get rid of
all the iswitchb stuff. Good times ahead...
Rasmus
--
This is the kind of tedious nonsense up with which I will not put
next prev parent reply other threads:[~2015-06-25 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 13:15 Unclear org-icompleting-read interface Oleh Krehel
2015-06-25 13:51 ` Nicolas Goaziou
2015-06-25 14:23 ` Oleh Krehel
2015-06-25 14:36 ` Rasmus [this message]
2015-06-25 16:30 ` Nicolas Goaziou
2015-06-25 16:39 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twtvlusk.fsf@gmx.us \
--to=rasmus@gmx.us \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).