From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Unclear org-icompleting-read interface
Date: Thu, 25 Jun 2015 15:51:50 +0200
Message-ID: <877fqryjyh.fsf@nicolasgoaziou.fr>
References: <87vbecudww.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33589)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Z87Xp-0006cO-HS
	for emacs-orgmode@gnu.org; Thu, 25 Jun 2015 09:50:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Z87Xo-0002s7-Ng
	for emacs-orgmode@gnu.org; Thu, 25 Jun 2015 09:50:21 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:59211)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Z87Xo-0002pY-HQ
	for emacs-orgmode@gnu.org; Thu, 25 Jun 2015 09:50:20 -0400
In-Reply-To: <87vbecudww.fsf@gmail.com> (Oleh Krehel's message of "Thu, 25 Jun
	2015 15:15:59 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Oleh Krehel <ohwoeowho@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Oleh Krehel <ohwoeowho@gmail.com> writes:

> The current `org-icompleting-read' is defined as taking only `&rest
> args', which can be as many as 8, all of them without a name.
>
> I propose to update the definition to:
>
>     (cl-defun org-icompleting-read (prompt collection
>                                     &key predicate require-match
>                                       initial-input hist def inherit-input-method)
>       ;; ...
>       )

I'd rather not use cl-defun in code base, which is slightly more
difficult to understand, and hardly unavoidable. Moreover,
`org-icompleting-read' is not harder to read as `completing-read'
anyway.

> This change would make the calls to `org-icompleting-read' much easier
> to read.

While we're at it, I suggest instead to make `org-icompleting-read' an
obsolete alias for `completing-read' in Org 8.4.
`partial-completing-mode' is obsolete since Emacs 24.1.


Regards,

-- 
Nicolas Goaziou