emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Problem at capture time
@ 2012-01-07 16:52 François Pinard
  2012-01-07 17:25 ` François Pinard
  2012-01-09  9:59 ` Bastien
  0 siblings, 2 replies; 7+ messages in thread
From: François Pinard @ 2012-01-07 16:52 UTC (permalink / raw)
  To: emacs-orgmode

Hi, Org people.

On 2011-12-11 23:24, I reported a problem met while using the Org
capture facility, and a patch working around the problem.  David Maus
then requested for details, which I sent on 2011-12-19 00:59.  David's
mailer rejected my reply as being likely SPAM, but it made it to the
emacs-orgmode@gnu.org mailing list, so I presume David got it.  Here are
references I have for both messages:

- [[gnus:gmane.emacs.orgmode#8739cqo1s3.fsf@iro.umontreal.ca][Email from
François Pinard: Capture failure {7.7}]]
- [[gnus:gmane.emacs.orgmode#871us1f6fo.fsf@iro.umontreal.ca][Email from François Pinard: Re: Capture failure {7.7}]]

This morning, I removed my patch locally.  Using a fresh Git pull of Org
mode,  the problem is still there, showing as:

Debugger entered--Lisp error: (error "Capture template `d': integer-or-marker-p")
  signal(error ("Capture template `d': integer-or-marker-p"))
  error("Capture template `%s': %s" "d" integer-or-marker-p)
  byte-code("\301p!\203.\0\302\303\304 \"\203.\0\305p!\210\306\307\310!!\210\300\311\307\312!\bA@#\207" [error buffer-base-buffer string-match "\\`CAPTURE-" buffer-name kill-buffer set-window-configuration org-capture-get :return-to-wconf "Capture template `%s': %s" :key] 4)
  org-capture(nil)
  call-interactively(org-capture nil nil)

The problem, which I described two months ago, is that some variables in
org-capture.el (org-capture-place-item) do not get properly initialized
depending on the flow within the function.  The following patch solves
the problem for me:


diff --git a/lisp/org-capture.el b/lisp/org-capture.el
index 46202f8..508611d 100644
--- a/lisp/org-capture.el
+++ b/lisp/org-capture.el
@@ -913,7 +913,8 @@ it.  When it is a variable, retrieve the value.  Return whatever we get."
         beg end)
     (cond
      ((org-capture-get :exact-position)
-      (goto-char (org-capture-get :exact-position)))
+      (goto-char (org-capture-get :exact-position))
+      (setq beg (point) end (point)))
      ((not target-entry-p)
       ;; Insert as top-level entry, either at beginning or at end of file
       (setq beg (point-min) end (point-max)))


Could it be integrated in the main stream?  I'm not sure that "(point)"
is the best value to give for "beg" and "end" (I do not understand the
code enough), but surely, this is better than capture just crashing.

François

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-01-24 17:39 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-07 16:52 Problem at capture time François Pinard
2012-01-07 17:25 ` François Pinard
2012-01-09  9:59 ` Bastien
2012-01-09 12:50   ` François Pinard
2012-01-24  6:23     ` David Maus
2012-01-24 16:13       ` Bastien
2012-01-24 17:39         ` François Pinard

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).