From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org
Subject: Re: Feature request: lists with letters
Date: Mon, 13 Feb 2017 21:39:29 +0100 [thread overview]
Message-ID: <874lzxlta6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87vaseni84.fsf@gmx.us> (rasmus@gmx.us's message of "Mon, 13 Feb 2017 17:55:23 +0100")
Hello,
Rasmus <rasmus@gmx.us> writes:
> Here's a quick attempt. Do you want me to push it?
Thank you. Some minor comments below. Feel free to push whenever you
think this is good enough.
> +(defconst org-html-plain-list-type
> + '(ordered "ol" unordered "ul" descriptive "dl")
> + "Plist of Org and html list types.")
I think this is not needed. We should merge `org-html-begin-plain-list'
and `org-html-end-plain-list' into `org-html-plain-list'. There is no
reason to split it.
As a consequence, we can compute "ol", "ul" or "dl" at the beginning of
`org-html-plain-list' and be done with it.
> + (let* ((html-type (plist-get org-html-plain-list-type type))
> + (html-class (format "org-%s" html-type)))
> + (format "<%s %s>"
> + html-type
> + (org-html--make-attribute-string
> + (plist-put attributes :class
> + (org-trim
> + (mapconcat 'identity
#'identity
> + (list html-class (plist-get attributes :class))
> + " ")))))))
>
> (defun org-html-end-plain-list (type)
> "Insert the end of the HTML list depending on TYPE."
> - (pcase type
> - (`ordered "</ol>")
> - (`unordered "</ul>")
> - (`descriptive "</dl>")))
> + (format "</%s>" (plist-get org-html-plain-list-type type)))
See. There is no need to make this one-liner a separate function, IMO.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-02-13 20:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1622a63fda844eb1aa553fdcd19a5758@HE1PR01MB1898.eurprd01.prod.exchangelabs.com>
2017-02-03 12:40 ` Feature request: lists with letters Eric S Fraga
2017-02-03 13:47 ` Titus von der Malsburg
2017-02-06 15:34 ` Rasmus
2017-02-06 19:59 ` Titus von der Malsburg
2017-02-09 9:29 ` Rasmus
2017-02-10 10:58 ` Titus von der Malsburg
2017-02-11 1:20 ` Nicolas Goaziou
2017-02-13 10:51 ` Rasmus
2017-02-13 13:47 ` Nicolas Goaziou
2017-02-13 16:55 ` Rasmus
2017-02-13 20:39 ` Nicolas Goaziou [this message]
2017-02-14 11:25 ` Rasmus
2017-02-14 12:57 ` Nicolas Goaziou
[not found] ` <9385a1ca2a23417399fb441d6d85795d@HE1PR01MB1898.eurprd01.prod.exchangelabs.com>
2017-02-11 12:39 ` Eric S Fraga
2017-02-03 11:37 Titus von der Malsburg
-- strict thread matches above, loose matches on Subject: below --
2017-02-02 17:28 Titus von der Malsburg
2017-02-02 17:55 ` Nicolas Goaziou
2017-02-02 19:42 ` Titus von der Malsburg
2017-02-02 19:57 ` Nicolas Goaziou
2017-02-02 20:05 ` Titus von der Malsburg
2017-02-02 20:19 ` Nicolas Goaziou
2017-02-02 20:33 ` Eric Abrahamsen
2017-02-03 8:50 ` Rainer M Krug
2017-02-03 16:22 ` William Denton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lzxlta6.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).