emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* test-org-cite/main-affixes failure
@ 2021-11-06 17:44 Kyle Meyer
  2021-11-06 20:44 ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Kyle Meyer @ 2021-11-06 17:44 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

Hi Nicolas,

test-org-cite/main-affixes, added in ad4028286 (oc: Refactor affixes
extraction, 2021-11-03), is failing on my end:

  $ BTEST_RE=main-affixes make test-dirty
  [...]
  Test test-org-cite/main-affixes condition:
      (ert-test-failed
       ((should
         (equal '...
  	(org-test-with-temp-text "[cite:@key1 post1;@key2 post2; global post]" ...)))
        :form
        (equal
         (nil "global post")
         (nil
  	#(" global post" 0 12 ...)))
        :value nil :explanation
        (list-elt 1
  		(arrays-of-different-length 11 12 "global post"
  					    #(" global post" 0 12 ...)
  					    first-mismatch-at 0))))
     FAILED  1/1  test-org-cite/main-affixes (0.009342 sec)
  [...]

Adding a space to the expected SUFFIX (as in the diff below) makes the
test pass for me and looks to be consistent with some of the other cases
in that test.

Does the current version of the test (no space) pass on your end?


diff --git a/testing/lisp/test-oc.el b/testing/lisp/test-oc.el
index c700780fe..896870303 100644
--- a/testing/lisp/test-oc.el
+++ b/testing/lisp/test-oc.el
@@ -286,7 +286,7 @@ (ert-deftest test-org-cite/main-affixes ()
           (org-test-with-temp-text "[cite:global pre;pre1 @key1;pre2 @key2]"
             (org-cite-main-affixes (org-element-context)))))
   (should
-   (equal '(nil . ("global post"))
+   (equal '(nil . (" global post"))
           (org-test-with-temp-text "[cite:@key1 post1;@key2 post2; global post]"
             (org-cite-main-affixes (org-element-context))))))
 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: test-org-cite/main-affixes failure
  2021-11-06 17:44 test-org-cite/main-affixes failure Kyle Meyer
@ 2021-11-06 20:44 ` Nicolas Goaziou
  2021-11-06 21:19   ` Kyle Meyer
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2021-11-06 20:44 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-orgmode

Hello,

Kyle Meyer <kyle@kyleam.com> writes:

> Hi Nicolas,
>
> test-org-cite/main-affixes, added in ad4028286 (oc: Refactor affixes
> extraction, 2021-11-03), is failing on my end:
>

[...]

> Adding a space to the expected SUFFIX (as in the diff below) makes the
> test pass for me and looks to be consistent with some of the other cases
> in that test.
>
> Does the current version of the test (no space) pass on your end?

No idea. I haven't been able to run any test during the past week, at
least (due to a silly error about missing ob-vala). I wrote these tests
blind, secretly hoping I would not introduce a mistake like the one
you're reporting.

Anyway, you're certainly right about the fix. You can push it.

Thank you.

Regards,
-- 
Nicolas Goaziou


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: test-org-cite/main-affixes failure
  2021-11-06 20:44 ` Nicolas Goaziou
@ 2021-11-06 21:19   ` Kyle Meyer
  2021-11-06 21:53     ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Kyle Meyer @ 2021-11-06 21:19 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

Nicolas Goaziou writes:

> Kyle Meyer <kyle@kyleam.com> writes:
[...]
>> Does the current version of the test (no space) pass on your end?
>
> No idea. I haven't been able to run any test during the past week, at
> least (due to a silly error about missing ob-vala).

Hmm, after ob-vala.el was removed from the repo, I believe I saw a
similar failure and needed to remove "vala" from the BTEST_OB_LANGUAGES
value in local.mk.

> Anyway, you're certainly right about the fix. You can push it.

Okay, thanks for the confirmation.  Pushed.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: test-org-cite/main-affixes failure
  2021-11-06 21:19   ` Kyle Meyer
@ 2021-11-06 21:53     ` Nicolas Goaziou
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2021-11-06 21:53 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-orgmode

Kyle Meyer <kyle@kyleam.com> writes:

> Hmm, after ob-vala.el was removed from the repo, I believe I saw a
> similar failure and needed to remove "vala" from the BTEST_OB_LANGUAGES
> value in local.mk.

Ah that was it! Oddly, my grep-fu couldn't catch it. Ah well. Thanks.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-06 21:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-06 17:44 test-org-cite/main-affixes failure Kyle Meyer
2021-11-06 20:44 ` Nicolas Goaziou
2021-11-06 21:19   ` Kyle Meyer
2021-11-06 21:53     ` Nicolas Goaziou

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).