From: Nicolas Goaziou <mail@nicolasgoaziou.fr> To: Kyle Meyer <kyle@kyleam.com> Cc: emacs-orgmode@gnu.org Subject: Re: test-org-cite/main-affixes failure Date: Sat, 06 Nov 2021 21:44:11 +0100 [thread overview] Message-ID: <878ry1ovz8.fsf@nicolasgoaziou.fr> (raw) In-Reply-To: <875yt56uxp.fsf@kyleam.com> (Kyle Meyer's message of "Sat, 06 Nov 2021 13:44:02 -0400") Hello, Kyle Meyer <kyle@kyleam.com> writes: > Hi Nicolas, > > test-org-cite/main-affixes, added in ad4028286 (oc: Refactor affixes > extraction, 2021-11-03), is failing on my end: > [...] > Adding a space to the expected SUFFIX (as in the diff below) makes the > test pass for me and looks to be consistent with some of the other cases > in that test. > > Does the current version of the test (no space) pass on your end? No idea. I haven't been able to run any test during the past week, at least (due to a silly error about missing ob-vala). I wrote these tests blind, secretly hoping I would not introduce a mistake like the one you're reporting. Anyway, you're certainly right about the fix. You can push it. Thank you. Regards, -- Nicolas Goaziou
next prev parent reply other threads:[~2021-11-06 20:44 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-06 17:44 Kyle Meyer 2021-11-06 20:44 ` Nicolas Goaziou [this message] 2021-11-06 21:19 ` Kyle Meyer 2021-11-06 21:53 ` Nicolas Goaziou
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=878ry1ovz8.fsf@nicolasgoaziou.fr \ --to=mail@nicolasgoaziou.fr \ --cc=emacs-orgmode@gnu.org \ --cc=kyle@kyleam.com \ --subject='Re: test-org-cite/main-affixes failure' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).