* org-save-outline-visibility no longer saves drawer visibility
@ 2018-02-03 0:16 Dale Sedivec
2018-02-11 10:45 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Dale Sedivec @ 2018-02-03 0:16 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]
Hi! I think maybe there's a bug in org-save-outline-visibility, or else I
misunderstand what that macro is supposed to do. Test case:
1. Start Emacs 26.0.91 with -Q and load org-mode from master
(release_9.1.6-419-g4b2006).
2. Make an org-mode buffer with contents:
~~~~~~
* Foo
:PROPERTIES:
:bar: baz
:END:
~~~~~~
3. Fold the PROPERTIES drawer by moving to the line with :PROPERTIES: and
hitting TAB.
4. M-: (org-save-outline-visibility t (org-show-all)) RET
Expected result: PROPERTIES drawer is still folded
Observed result: PROPERTIES drawer is no longer folded, its contents have
become visible
Should org-save-outline-visibility save the visibility of drawers along
with other visibility?
I am wondering if this is perhaps a consequence of 4403d4685e19, "Give
drawers their own invisibility spec", where the 'org-hide-drawer
invisibility spec was introduced? As a consequence,
org-outline-overlay-data (called by org-save-outline-visibility) no longer
saves the invisible overlays for drawers, since those overlays' 'invisible
property is no longer 'outline, but instead 'org-hide-drawer.
Thanks,
Dale
[-- Attachment #2: Type: text/html, Size: 1521 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: org-save-outline-visibility no longer saves drawer visibility
2018-02-03 0:16 org-save-outline-visibility no longer saves drawer visibility Dale Sedivec
@ 2018-02-11 10:45 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2018-02-11 10:45 UTC (permalink / raw)
To: Dale Sedivec; +Cc: emacs-orgmode
Hello,
Dale Sedivec <dale@codefu.org> writes:
> 2. Make an org-mode buffer with contents:
>
> ~~~~~~
> * Foo
> :PROPERTIES:
> :bar: baz
> :END:
> ~~~~~~
>
> 3. Fold the PROPERTIES drawer by moving to the line with :PROPERTIES: and
> hitting TAB.
>
> 4. M-: (org-save-outline-visibility t (org-show-all)) RET
>
> Expected result: PROPERTIES drawer is still folded
>
> Observed result: PROPERTIES drawer is no longer folded, its contents have
> become visible
Fixed. Thank you!
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-11 10:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-03 0:16 org-save-outline-visibility no longer saves drawer visibility Dale Sedivec
2018-02-11 10:45 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).