From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dale Sedivec Subject: org-save-outline-visibility no longer saves drawer visibility Date: Fri, 2 Feb 2018 18:16:06 -0600 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113aca3496a93d056443be0f" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehlVh-0008VQ-9Z for emacs-orgmode@gnu.org; Fri, 02 Feb 2018 19:16:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehlVg-0008KR-Al for emacs-orgmode@gnu.org; Fri, 02 Feb 2018 19:16:49 -0500 Received: from mail-qk0-x232.google.com ([2607:f8b0:400d:c09::232]:34619) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ehlVg-0008KE-1t for emacs-orgmode@gnu.org; Fri, 02 Feb 2018 19:16:48 -0500 Received: by mail-qk0-x232.google.com with SMTP id m130so1150234qke.1 for ; Fri, 02 Feb 2018 16:16:47 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org --001a113aca3496a93d056443be0f Content-Type: text/plain; charset="UTF-8" Hi! I think maybe there's a bug in org-save-outline-visibility, or else I misunderstand what that macro is supposed to do. Test case: 1. Start Emacs 26.0.91 with -Q and load org-mode from master (release_9.1.6-419-g4b2006). 2. Make an org-mode buffer with contents: ~~~~~~ * Foo :PROPERTIES: :bar: baz :END: ~~~~~~ 3. Fold the PROPERTIES drawer by moving to the line with :PROPERTIES: and hitting TAB. 4. M-: (org-save-outline-visibility t (org-show-all)) RET Expected result: PROPERTIES drawer is still folded Observed result: PROPERTIES drawer is no longer folded, its contents have become visible Should org-save-outline-visibility save the visibility of drawers along with other visibility? I am wondering if this is perhaps a consequence of 4403d4685e19, "Give drawers their own invisibility spec", where the 'org-hide-drawer invisibility spec was introduced? As a consequence, org-outline-overlay-data (called by org-save-outline-visibility) no longer saves the invisible overlays for drawers, since those overlays' 'invisible property is no longer 'outline, but instead 'org-hide-drawer. Thanks, Dale --001a113aca3496a93d056443be0f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!=C2=A0 I think maybe there's a bug in org-save-outl= ine-visibility, or else I misunderstand what that macro is supposed to do.= =C2=A0 Test case:

1. Start Emacs 26.0.91 with -Q and loa= d org-mode from master (release_9.1.6-419-g4b2006).

2. Make an org-mode buffer with contents:

~~~~~~=
* Foo
=C2=A0 :PROPERTIES:
=C2=A0 :bar:= =C2=A0 =C2=A0 =C2=A0 baz
=C2=A0 :END:
~~~~~~

3. Fold the PROPERTIES drawer by moving to the li= ne with :PROPERTIES: and hitting TAB.

4. M-:=C2=A0= (org-save-outline-visibility t (org-show-all)) RET

Expected result: PROPERTIES drawer is still folded

Observed result: PROPERTIES drawer is no longer folded, its contents have= become visible

Should org-save-outline-visibility= save the visibility of drawers along with other visibility?

=
I am wondering if this is perhaps a consequence of=C2=A04403d468= 5e19, "Give drawers their own invisibility spec", where the '= org-hide-drawer invisibility spec was introduced?=C2=A0 As a consequence, o= rg-outline-overlay-data (called by org-save-outline-visibility) no longer s= aves the invisible overlays for drawers, since those overlays' 'inv= isible property is no longer 'outline, but instead 'org-hide-drawer= .

Thanks,
Dale
--001a113aca3496a93d056443be0f--