From: Ihor Radchenko <firstname.lastname@example.org> To: Max Nikulin <email@example.com> Cc: firstname.lastname@example.org, Paul Eggert <email@example.com> Subject: Re: [PATCH v3] org-encode-time compatibility and convenience helper Date: Wed, 04 May 2022 17:56:08 +0800 [thread overview] Message-ID: <8735hpk4ef.fsf@localhost> (raw) In-Reply-To: <firstname.lastname@example.org> Max Nikulin <email@example.com> writes: > The attached patch set is assumed to be complete. Thanks! > I have no chance to thoroughly test it. Existing unit tests pass for > Emacs-26 and Emacs-27. Nothing has changed for Emacs-25, as for the > "main" branch one test fails. I have not tried Emacs-28 or the current > git version. I tried to test your patch applied onto main with all the supported Emacs versions (note that we do not need to support Emacs 25 anymore. Emacs 28 is out). One test is failing: Emacs 26, 27, 28, and 29: 1 unexpected results: FAILED test-org-clock/clocktable/ranges > In comparison to the previous patch version I have expanded the > docstring and added a bit more tests. I have tried to support recently > committed to Emacs 6-elements list for `encode-time', but I do not like > the following compile-time warning: > >> In toplevel form: >> org-macs.el:1397:23:Warning: encode-time called with 1 argument, but requires >> 6+ Since it is expected to fail in some Emacs versions, you can just wrap the call into with-no-warnings: (ignore-errors (with-no-warnings (encode-time '(0 0 0 1 1 1971)))) Best, Ihor
next prev parent reply other threads:[~2022-05-04 11:02 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-11 15:22 [DRAFT][PATCH] " Max Nikulin 2022-04-11 17:43 ` Paul Eggert 2022-04-23 8:25 ` Ihor Radchenko 2022-04-23 19:37 ` Paul Eggert 2022-04-24 3:35 ` Ihor Radchenko 2022-04-24 11:34 ` [DRAFT][PATCH v2] " Max Nikulin 2022-04-26 9:07 ` Ihor Radchenko 2022-05-03 12:14 ` [PATCH v3] " Max Nikulin 2022-05-04 9:56 ` Ihor Radchenko [this message] 2022-05-04 16:49 ` Max Nikulin 2022-05-05 15:22 ` [PATCH v4] " Max Nikulin 2022-05-07 4:46 ` Ihor Radchenko 2022-05-10 14:31 ` Max Nikulin 2022-05-11 13:20 ` Ihor Radchenko 2022-05-13 15:14 ` Max Nikulin 2022-05-14 6:06 ` Ihor Radchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8735hpk4ef.fsf@localhost \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v3] org-encode-time compatibility and convenience helper' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).