From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aHNHGUBdcmLzLQAAbAwnHQ (envelope-from ) for ; Wed, 04 May 2022 13:02:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2O5gGUBdcmKUkQAA9RJhRA (envelope-from ) for ; Wed, 04 May 2022 13:02:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F12BF6AF7 for ; Wed, 4 May 2022 13:02:23 +0200 (CEST) Received: from localhost ([::1]:53838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmClz-0006fA-3W for larch@yhetil.org; Wed, 04 May 2022 07:02:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmBjC-0001jS-0J for emacs-orgmode@gnu.org; Wed, 04 May 2022 05:55:27 -0400 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]:39733) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmBjA-0004mW-F9 for emacs-orgmode@gnu.org; Wed, 04 May 2022 05:55:25 -0400 Received: by mail-pj1-x102c.google.com with SMTP id a15-20020a17090ad80f00b001dc2e23ad84so4723632pjv.4 for ; Wed, 04 May 2022 02:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=cj11igOxZbJeF7TiBAtsZJHdPr+y6NDWcf2P4WEYeTI=; b=ejR+O31AgiRBPiIOUEW7oyJ/I5H1BbCKs3Kffk6Ce2hEmo5IlCbD7ApXv/ZeWdvuJv JvqadTa/Uvs4B3WJux4o4sK2Jz4G0nH1bACQjQ1x+IHf+QlwEbYo5cnhXUiItCqwJbOv 3QxJuQluSS5FLGFPpv2ahJ9FJc53+eZYToCYsOmmau2zTS5Cbktm3Jt2HCCdE5pTGfgi ke5aHLbtey6jRI6MlBXfwRcCgx1j7ttVHErC+AZTNxHDXyALpCVJpFkjJrcGTqfxY280 qZK0UZsRjEPv2+SoKoSjLk6mVjVmdfCKd8vGjeAGVctQ2dTG51rFWfVlxmHkpMybosrY LZRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=cj11igOxZbJeF7TiBAtsZJHdPr+y6NDWcf2P4WEYeTI=; b=vg0zO+gDq0c2KPuva76h/xCg6bnp9uS9Hqy7F+8grWPo0VlVzu/5cq4IqcH8NsxU+W uEGUmhZrvYQ34re5uCU4oBA3to4x8xSJnNC/8XFkLCbl4Mz/NHf0Y0/YKB8bbAex7NoT k3jQg0Z/rhTSt50xXV1Iu/aQgQAHzvETBxTPZCbkQXlnN8dt8rc0NcKftFEMt7YNo+I3 mjwJeJ3asvNA88xZaq5hpa0thAwe6nfuYjuFYsQSH5fPuN0Ndvk32DP3OMXUc/FjIfqk YqAGMki31iHsy44A9g5h4UxmieBgDyTsQf6yXE/Wgk3N1SMrEFzIZdhZH7OC0pjYDJMf DacQ== X-Gm-Message-State: AOAM533lMojMx1+6yFnVkc/or0RzSGrf0DPutnHWyA0z1d3cFEIHuu3M fUwKkbkRWZelzqxQpbg25NGYxoimIhqZIgfFekM= X-Google-Smtp-Source: ABdhPJw111PePm9YQdDgL6CVjwrxzE4mLvceU6wk4qp7viQl6L+Vmb1bDqnjYZWcsmUKqzTXAz8bGQ== X-Received: by 2002:a17:902:d402:b0:15e:cae9:cc47 with SMTP id b2-20020a170902d40200b0015ecae9cc47mr938916ple.100.1651658123039; Wed, 04 May 2022 02:55:23 -0700 (PDT) Received: from localhost ([37.120.210.2]) by smtp.gmail.com with ESMTPSA id 3-20020a170902c20300b0015e8d4eb20esm7894409pll.88.2022.05.04.02.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 02:55:22 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org, Paul Eggert Subject: Re: [PATCH v3] org-encode-time compatibility and convenience helper In-Reply-To: References: <7f4ea652-7d22-fb61-f873-5e92f078c9e6@gmail.com> <87mtgcmckj.fsf@localhost> <875ymwus9p.fsf@localhost> Date: Wed, 04 May 2022 17:56:08 +0800 Message-ID: <8735hpk4ef.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=yantar92@gmail.com; helo=mail-pj1-x102c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651662144; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cj11igOxZbJeF7TiBAtsZJHdPr+y6NDWcf2P4WEYeTI=; b=dMXKBQF2cv1rFpOQtXTNAFSsXVJ/nOgK5n6S8hjgv01VUVm7yHWQhfCnjnGrOkun/LftIv mL5C81XCJ4Gmhv0FdLX3S5aKLjS/QFAiM088+3HSd3sMcXDksg3QtftAomuscMPNucX+FY msA/DEC3k1V76UoCLFIszXqagbvDb/CFEVXjKUw1RmXizid5mrMHp4IwcN9pfRfLYo/pt9 yWeUYj1d/cS8YsB7OhfqBD45c632SJx0lVNpMuWKDtV8ZMMtfzZIjB6wswnTPqh7Le7/Qd BuGhmu0ORO0rqruQkWcwzY31tpwiDoZcSR1hy/co+9ecu+Gox1mSqoHSqhtnfQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651662144; a=rsa-sha256; cv=none; b=XeSq3K7aPOlr/UYJm8kInewanFyaVFwHghMajZ1/Bs7wEZtb1WztK51Oml2Ue30TGecZyF 2ubvbtcoKj+e95W5PgN0pg18BhaHXgZoHdB0gVcVel/3nlGP3CqdxfdDIPXisHf4GqaMT0 c7055uOKTX0e694Mi/NvPljBj2HbG4M4LyhmUtNYp7677BzU9wSB2Xng/Tf3v7qxLZSqlS dASTwODDbK0g3zopfLSqU4GSNuVspbuWSIU82GZZvt2l2XrkswGH/J+GVp2rvBCOA9k0Nn eyb4SjgM9tz4MmZArwOKEbjTepYHutSHw44wI/FgnCWwnNlAXHr25kno6/4nKA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ejR+O31A; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.98 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ejR+O31A; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F12BF6AF7 X-Spam-Score: -1.98 X-Migadu-Scanner: scn1.migadu.com X-TUID: x3FKBfnZfrEh Max Nikulin writes: > The attached patch set is assumed to be complete. Thanks! > I have no chance to thoroughly test it. Existing unit tests pass for > Emacs-26 and Emacs-27. Nothing has changed for Emacs-25, as for the > "main" branch one test fails. I have not tried Emacs-28 or the current > git version. I tried to test your patch applied onto main with all the supported Emacs versions (note that we do not need to support Emacs 25 anymore. Emacs 28 is out). One test is failing: Emacs 26, 27, 28, and 29: 1 unexpected results: FAILED test-org-clock/clocktable/ranges > In comparison to the previous patch version I have expanded the > docstring and added a bit more tests. I have tried to support recently > committed to Emacs 6-elements list for `encode-time', but I do not like > the following compile-time warning: > >> In toplevel form: >> org-macs.el:1397:23:Warning: encode-time called with 1 argument, but requires >> 6+ Since it is expected to fail in some Emacs versions, you can just wrap the call into with-no-warnings: (ignore-errors (with-no-warnings (encode-time '(0 0 0 1 1 1971)))) Best, Ihor