From: Ihor Radchenko <firstname.lastname@example.org> To: Max Nikulin <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [DRAFT][PATCH v2] org-encode-time compatibility and convenience helper Date: Tue, 26 Apr 2022 17:07:46 +0800 [thread overview] Message-ID: <875ymwus9p.fsf@localhost> (raw) In-Reply-To: <email@example.com> Max Nikulin <firstname.lastname@example.org> writes: >> This whole timezone staff is complex. I got lost in the emacs devel >> discussion half-way through. From point of view of API, I would prefer a >> single function with docstring explaining the necessary caveats. > > To have namely a single function that accepts both a list or multiple > arguments, it is necessary to introduce a new name to Emacs. > `encode-time' has a subtle difference in behavior depending on the > calling style and fixing this issue may break some code. That is why I > decided to offer a macro. I did not mean "single function" to be a function specifically. Macro is perfectly fine. Sorry for the confusion. > I have not figured out which kind of high-level API I would like to have > instead of `encode-time', and I believe, it is acceptable to rely on > default normalization and ambiguity resolution as the status quo. > Problems may happen during 2 days of 365 and people usually expect some > glitches for these days. There are too many caveats to explain them in > docstring. I understand. But, it may be helpful to mention the existence of such caveats, ideally with a link where the user can learn more. > I am attaching an updated version of the draft. I have added a macro for > testing of particular time zones. > From 8fdcca3f3b0cf3e890149eb79ea6c7970b7d2cfa Mon Sep 17 00:00:00 2001 > From: Max Nikulin <email@example.com> > Date: Fri, 8 Apr 2022 23:10:50 +0700 > Subject: [PATCH] org-macs.el: Introduce a helper for `encode-time' LGTM. I think you can go ahead and continue with the followup patch making use of the new macro. Best, Ihor
next prev parent reply other threads:[~2022-04-26 9:16 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-11 15:22 [DRAFT][PATCH] " Max Nikulin 2022-04-11 17:43 ` Paul Eggert 2022-04-23 8:25 ` Ihor Radchenko 2022-04-23 19:37 ` Paul Eggert 2022-04-24 3:35 ` Ihor Radchenko 2022-04-24 11:34 ` [DRAFT][PATCH v2] " Max Nikulin 2022-04-26 9:07 ` Ihor Radchenko [this message] 2022-05-03 12:14 ` [PATCH v3] " Max Nikulin 2022-05-04 9:56 ` Ihor Radchenko 2022-05-04 16:49 ` Max Nikulin 2022-05-05 15:22 ` [PATCH v4] " Max Nikulin 2022-05-07 4:46 ` Ihor Radchenko 2022-05-10 14:31 ` Max Nikulin 2022-05-11 13:20 ` Ihor Radchenko 2022-05-13 15:14 ` Max Nikulin 2022-05-14 6:06 ` Ihor Radchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=875ymwus9p.fsf@localhost \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [DRAFT][PATCH v2] org-encode-time compatibility and convenience helper' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).