emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Org release 7.8.07 (BUGFIX-only release)
@ 2012-03-31 10:07 Bastien
  2012-03-31 13:22 ` Achim Gratz
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Bastien @ 2012-03-31 10:07 UTC (permalink / raw)
  To: emacs-orgmode

Hi all,

I have just released Org 7.8.07 -- a BUGFIX-only release.

This is the version that will be merged into Emacs' trunk
by tomorrow.  Please report critical bugs using "URGENT"
in the subject line.

Thanks all for your help!

  http://orgmode.org/org-7.8.07.zip
  http://orgmode.org/org-7.8.07.tar.gz
  http://orgmode.org/org-mode-download.html

Enjoy,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Org release 7.8.07 (BUGFIX-only release)
  2012-03-31 10:07 Org release 7.8.07 (BUGFIX-only release) Bastien
@ 2012-03-31 13:22 ` Achim Gratz
  2012-04-01  8:37   ` Bastien
  2012-03-31 17:00 ` Eric Schulte
  2012-04-01 10:03 ` Bastien
  2 siblings, 1 reply; 9+ messages in thread
From: Achim Gratz @ 2012-03-31 13:22 UTC (permalink / raw)
  To: emacs-orgmode

Bastien writes:
> This is the version that will be merged into Emacs' trunk
> by tomorrow.

Please tag the release on maint so that Git reports the correct version.

>  Please report critical bugs using "URGENT"
> in the subject line.

All tests (except for R which I can't run due to lack of ESS) are clean
on openSUSE/Tumbleweed with both Emacs 23.4 and 24.0.94.

> Thanks all for your help!

I'm still getting these complaints about unprefixed / global variables
w/ latest Emacs24 from trunk and fresh pull from master:

In toplevel form:
org.el:4871:1:Warning: global/dynamic var `date' lacks a prefix

In toplevel form:
org-agenda.el:95:1:Warning: global/dynamic var `date' lacks a prefix

In toplevel form:
org-bbdb.el:122:1:Warning: global/dynamic var `date' lacks a prefix
org-bbdb.el:123:1:Warning: global/dynamic var `name' lacks a prefix

In toplevel form:
org-remember.el:280:1:Warning: global/dynamic var `annotation' lacks a prefix
org-remember.el:281:1:Warning: global/dynamic var `initial' lacks a prefix


There is something going on in org-compat that I don't understand at all
(note that find-library is not called at that poit at all, so there must
be some macro expansion at work).  This is also in Emacs23:

In org-find-library-name:
org-compat.el:341:14:Warning: find-library called with 3 arguments, but
    accepts only 1


Lastly, there's a function that has been obsoleted with Emacs24, so it
should probably get a shim in org-compat to refer to one or the other
definition based on Emacs version in a with-no-error form.

In org-indent-mode:
org-indent.el:212:11:Warning: `buffer-substring-filters' is an obsolete
    variable (as of 24.1); use `filter-buffer-substring-functions' instead.
org-indent.el:213:12:Warning: `buffer-substring-filters' is an obsolete
    variable (as of 24.1); use `filter-buffer-substring-functions' instead.
org-indent.el:213:12:Warning: `buffer-substring-filters' is an obsolete
    variable (as of 24.1); use `filter-buffer-substring-functions' instead.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Waldorf MIDI Implementation & additional documentation:
http://Synth.Stromeko.net/Downloads.html#WaldorfDocs

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Org release 7.8.07 (BUGFIX-only release)
  2012-03-31 10:07 Org release 7.8.07 (BUGFIX-only release) Bastien
  2012-03-31 13:22 ` Achim Gratz
@ 2012-03-31 17:00 ` Eric Schulte
  2012-03-31 17:05   ` Eric Schulte
  2012-04-01 10:03 ` Bastien
  2 siblings, 1 reply; 9+ messages in thread
From: Eric Schulte @ 2012-03-31 17:00 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode

Bastien <bzg@gnu.org> writes:

> Hi all,
>
> I have just released Org 7.8.07 -- a BUGFIX-only release.
>
> This is the version that will be merged into Emacs' trunk
> by tomorrow.  Please report critical bugs using "URGENT"
> in the subject line.
>
> Thanks all for your help!
>
>   http://orgmode.org/org-7.8.07.zip
>   http://orgmode.org/org-7.8.07.tar.gz
>   http://orgmode.org/org-mode-download.html
>
> Enjoy,

Hi Bastien,

I've pushed two bug fixes up to the hotfix-7.8.06 branch this morning.
These should both be included in the code merged with Emacs.  I've
marked the emails related to these bugs as URGENT.

Cheers,

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Org release 7.8.07 (BUGFIX-only release)
  2012-03-31 17:00 ` Eric Schulte
@ 2012-03-31 17:05   ` Eric Schulte
  2012-04-01  8:40     ` Bastien
  0 siblings, 1 reply; 9+ messages in thread
From: Eric Schulte @ 2012-03-31 17:05 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode

Eric Schulte <eric.schulte@gmx.com> writes:

> Bastien <bzg@gnu.org> writes:
>
>> Hi all,
>>
>> I have just released Org 7.8.07 -- a BUGFIX-only release.
>>
>> This is the version that will be merged into Emacs' trunk
>> by tomorrow.  Please report critical bugs using "URGENT"
>> in the subject line.
>>
>> Thanks all for your help!
>>
>>   http://orgmode.org/org-7.8.07.zip
>>   http://orgmode.org/org-7.8.07.tar.gz
>>   http://orgmode.org/org-mode-download.html
>>
>> Enjoy,
>
> Hi Bastien,
>
> I've pushed two bug fixes up to the hotfix-7.8.06 branch this morning.
               ^
             three
> 
> These should both be included in the code merged with Emacs.  I've
> marked the emails related to these bugs as URGENT.
>
> Cheers,

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Org release 7.8.07 (BUGFIX-only release)
  2012-03-31 13:22 ` Achim Gratz
@ 2012-04-01  8:37   ` Bastien
  2012-04-01 10:39     ` Achim Gratz
  0 siblings, 1 reply; 9+ messages in thread
From: Bastien @ 2012-04-01  8:37 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-orgmode

Hi Achim,

Achim Gratz <Stromeko@nexgo.de> writes:

> Bastien writes:
>> This is the version that will be merged into Emacs' trunk
>> by tomorrow.
>
> Please tag the release on maint so that Git reports the correct
> version.

Done.  (I tagged locally but forgot to push the tag.)

>>  Please report critical bugs using "URGENT"
>> in the subject line.
>
> All tests (except for R which I can't run due to lack of ESS) are clean
> on openSUSE/Tumbleweed with both Emacs 23.4 and 24.0.94.

Yes.

>> Thanks all for your help!
>
> I'm still getting these complaints about unprefixed / global variables
> w/ latest Emacs24 from trunk and fresh pull from master:
>
> In toplevel form:
> org.el:4871:1:Warning: global/dynamic var `date' lacks a prefix
>
> In toplevel form:
> org-agenda.el:95:1:Warning: global/dynamic var `date' lacks a prefix
>
> In toplevel form:
> org-bbdb.el:122:1:Warning: global/dynamic var `date' lacks a prefix
> org-bbdb.el:123:1:Warning: global/dynamic var `name' lacks a prefix

The problem with the `name' global variable is not in maint, I will 
have a look in master.

> In toplevel form:
> org-remember.el:280:1:Warning: global/dynamic var `annotation' lacks a prefix
> org-remember.el:281:1:Warning: global/dynamic var `initial' lacks a prefix

Yes, I know.  

This is not easy to fix, because the ̀date' global variable is set from
calendar.  Same for annotation and initial, which are set from
remember.el.  If you see a place where the fix is trivial (i.e. where my
assumption is false), please submit it.

> There is something going on in org-compat that I don't understand at all
> (note that find-library is not called at that poit at all, so there must
> be some macro expansion at work).  This is also in Emacs23:
>
> In org-find-library-name:
> org-compat.el:341:14:Warning: find-library called with 3 arguments, but
>     accepts only 1

Well, this is the culprit compatibility defun:

(defun org-find-library-name (library)
  (if (fboundp 'find-library-name)
      (file-name-directory (find-library-name library))
    ; XEmacs does not have `find-library-name'
    (flet ((find-library-name-helper (filename ignored-codesys)
				     filename)
	   (find-library-name (library)
	    (find-library library nil 'find-library-name-helper)))  <<<<<
      (file-name-directory (find-library-name library)))))

I don't know how to circumvent this warning and btw I don't have this
warning in Emacs 24.0.94.1.

> Lastly, there's a function that has been obsoleted with Emacs24, so it
> should probably get a shim in org-compat to refer to one or the other
> definition based on Emacs version in a with-no-error form.
>
> In org-indent-mode:
> org-indent.el:212:11:Warning: `buffer-substring-filters' is an obsolete
>     variable (as of 24.1); use `filter-buffer-substring-functions' instead.
> org-indent.el:213:12:Warning: `buffer-substring-filters' is an obsolete
>     variable (as of 24.1); use `filter-buffer-substring-functions' instead.
> org-indent.el:213:12:Warning: `buffer-substring-filters' is an obsolete
>     variable (as of 24.1); use `filter-buffer-substring-functions' instead.

Yes.  The fix is not trivial.  Patch welcome!

Thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Org release 7.8.07 (BUGFIX-only release)
  2012-03-31 17:05   ` Eric Schulte
@ 2012-04-01  8:40     ` Bastien
  0 siblings, 0 replies; 9+ messages in thread
From: Bastien @ 2012-04-01  8:40 UTC (permalink / raw)
  To: Eric Schulte; +Cc: emacs-orgmode

Hi Eric,

Eric Schulte <eric.schulte@gmx.com> writes:

>> I've pushed two bug fixes up to the hotfix-7.8.06 branch this morning.
>                ^
>              three
>> 
>> These should both be included in the code merged with Emacs.  I've
>> marked the emails related to these bugs as URGENT.

Noted, thanks.  I will merge Org>Emacs from the hotfix branch.  But
let's keep this branch very "hot" (only critical bugfixes.)

Thanks!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Org release 7.8.07 (BUGFIX-only release)
  2012-03-31 10:07 Org release 7.8.07 (BUGFIX-only release) Bastien
  2012-03-31 13:22 ` Achim Gratz
  2012-03-31 17:00 ` Eric Schulte
@ 2012-04-01 10:03 ` Bastien
  2 siblings, 0 replies; 9+ messages in thread
From: Bastien @ 2012-04-01 10:03 UTC (permalink / raw)
  To: emacs-orgmode

Hi all,

Bastien <bzg@gnu.org> writes:

> I have just released Org 7.8.07 -- a BUGFIX-only release.
>
> This is the version that will be merged into Emacs' trunk
> by tomorrow.  Please report critical bugs using "URGENT"
> in the subject line.

Org 7.8.07 (commit da0e6f) is now part of Emacs trunk.

Best,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Org release 7.8.07 (BUGFIX-only release)
  2012-04-01  8:37   ` Bastien
@ 2012-04-01 10:39     ` Achim Gratz
  2012-04-02 19:53       ` Achim Gratz
  0 siblings, 1 reply; 9+ messages in thread
From: Achim Gratz @ 2012-04-01 10:39 UTC (permalink / raw)
  To: emacs-orgmode

Bastien writes:
>> In org-find-library-name:
>> org-compat.el:341:14:Warning: find-library called with 3 arguments, but
>>     accepts only 1
>
> Well, this is the culprit compatibility defun:
>
> (defun org-find-library-name (library)
>   (if (fboundp 'find-library-name)
>       (file-name-directory (find-library-name library))
>     ; XEmacs does not have `find-library-name'
>     (flet ((find-library-name-helper (filename ignored-codesys)
> 				     filename)
> 	   (find-library-name (library)
> 	    (find-library library nil 'find-library-name-helper)))  <<<<<
>       (file-name-directory (find-library-name library)))))
>
> I don't know how to circumvent this warning and btw I don't have this
> warning in Emacs 24.0.94.1.

I also do not have this warning when compiling org-compat.el in
isolation, but I do have this warning when I do a
batch-byte-recompile-directory.  That is never a good sign...

Anyway, I think that most if not all these defuns in org-compat.el
should really be macros (although careful quoting has to be applied) so
that the byte-compiler only needs to compile whatever is appropriate.

(defmacro org-find-library-name (library)
  (if (fboundp 'find-library-name)
      `(file-name-directory (find-library-name ,library))
    ; XEmacs does not have `find-library-name'
    `(flet ((find-library-name-helper (filename ignored-codesys)
				     filename)
	    (find-library-name (library)
	    (find-library library nil 'find-library-name-helper)))
      (file-name-directory (find-library-name ,library)))))

I also don't think an flet macro should be used here (or it should also
be expanded at compile time, which I can't see how to do easily), maybe
replace with a lambda expression?  Looking at the definition of
find-library in XEmacs makes me a bit queasy, but I think it needs three
arguments to tell it not to display the file in a window...

(defmacro org-find-library-name (library)
  (if (fboundp 'find-library-name)
      `(file-name-directory (find-library-name ,library))
    ; XEmacs does not have `find-library-name'
    `(file-name-directory (find-library ,library nil (lambda (lib ignore) lib)))))

Anyway, something to do after Emacs 24.1 is out.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Org release 7.8.07 (BUGFIX-only release)
  2012-04-01 10:39     ` Achim Gratz
@ 2012-04-02 19:53       ` Achim Gratz
  0 siblings, 0 replies; 9+ messages in thread
From: Achim Gratz @ 2012-04-02 19:53 UTC (permalink / raw)
  To: emacs-orgmode

Achim Gratz writes:
> (defmacro org-find-library-name (library)
>   (if (fboundp 'find-library-name)
>       `(file-name-directory (find-library-name ,library))
>     ; XEmacs does not have `find-library-name'
>     `(file-name-directory (find-library ,library nil (lambda (lib ignore) lib)))))

Scratch that, of course it needs to evaluate to a function... better
something like this:

(defmacro org-compat-when-fboundp (symbol form1 form2)
  (if (fboundp symbol)
      form1
    form2))
(org-compat-when-fboundp find-library-name
    (declare-function find-library-name "find-func"  (library))
  (declare-function find-library "lib-complete"  (library codesys func)))
(defun org-find-library-name (library)
  (org-compat-when-fboundp find-library-name
      (file-name-directory (find-library-name library))
    ; XEmacs does not have `find-library-name'
    (file-name-directory (find-library library nil (lambda (lib ignore) lib)))))


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for KORG EX-800 and Poly-800MkII V0.9:
http://Synth.Stromeko.net/Downloads.html#KorgSDada

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2012-04-02 19:53 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-31 10:07 Org release 7.8.07 (BUGFIX-only release) Bastien
2012-03-31 13:22 ` Achim Gratz
2012-04-01  8:37   ` Bastien
2012-04-01 10:39     ` Achim Gratz
2012-04-02 19:53       ` Achim Gratz
2012-03-31 17:00 ` Eric Schulte
2012-03-31 17:05   ` Eric Schulte
2012-04-01  8:40     ` Bastien
2012-04-01 10:03 ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).