From: Bastien <bzg@gnu.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Org release 7.8.07 (BUGFIX-only release)
Date: Sun, 01 Apr 2012 10:37:00 +0200 [thread overview]
Message-ID: <87ehs7hmqb.fsf@gnu.org> (raw)
In-Reply-To: <87ehs8kir5.fsf@Rainer.invalid> (Achim Gratz's message of "Sat, 31 Mar 2012 15:22:22 +0200")
Hi Achim,
Achim Gratz <Stromeko@nexgo.de> writes:
> Bastien writes:
>> This is the version that will be merged into Emacs' trunk
>> by tomorrow.
>
> Please tag the release on maint so that Git reports the correct
> version.
Done. (I tagged locally but forgot to push the tag.)
>> Please report critical bugs using "URGENT"
>> in the subject line.
>
> All tests (except for R which I can't run due to lack of ESS) are clean
> on openSUSE/Tumbleweed with both Emacs 23.4 and 24.0.94.
Yes.
>> Thanks all for your help!
>
> I'm still getting these complaints about unprefixed / global variables
> w/ latest Emacs24 from trunk and fresh pull from master:
>
> In toplevel form:
> org.el:4871:1:Warning: global/dynamic var `date' lacks a prefix
>
> In toplevel form:
> org-agenda.el:95:1:Warning: global/dynamic var `date' lacks a prefix
>
> In toplevel form:
> org-bbdb.el:122:1:Warning: global/dynamic var `date' lacks a prefix
> org-bbdb.el:123:1:Warning: global/dynamic var `name' lacks a prefix
The problem with the `name' global variable is not in maint, I will
have a look in master.
> In toplevel form:
> org-remember.el:280:1:Warning: global/dynamic var `annotation' lacks a prefix
> org-remember.el:281:1:Warning: global/dynamic var `initial' lacks a prefix
Yes, I know.
This is not easy to fix, because the ̀date' global variable is set from
calendar. Same for annotation and initial, which are set from
remember.el. If you see a place where the fix is trivial (i.e. where my
assumption is false), please submit it.
> There is something going on in org-compat that I don't understand at all
> (note that find-library is not called at that poit at all, so there must
> be some macro expansion at work). This is also in Emacs23:
>
> In org-find-library-name:
> org-compat.el:341:14:Warning: find-library called with 3 arguments, but
> accepts only 1
Well, this is the culprit compatibility defun:
(defun org-find-library-name (library)
(if (fboundp 'find-library-name)
(file-name-directory (find-library-name library))
; XEmacs does not have `find-library-name'
(flet ((find-library-name-helper (filename ignored-codesys)
filename)
(find-library-name (library)
(find-library library nil 'find-library-name-helper))) <<<<<
(file-name-directory (find-library-name library)))))
I don't know how to circumvent this warning and btw I don't have this
warning in Emacs 24.0.94.1.
> Lastly, there's a function that has been obsoleted with Emacs24, so it
> should probably get a shim in org-compat to refer to one or the other
> definition based on Emacs version in a with-no-error form.
>
> In org-indent-mode:
> org-indent.el:212:11:Warning: `buffer-substring-filters' is an obsolete
> variable (as of 24.1); use `filter-buffer-substring-functions' instead.
> org-indent.el:213:12:Warning: `buffer-substring-filters' is an obsolete
> variable (as of 24.1); use `filter-buffer-substring-functions' instead.
> org-indent.el:213:12:Warning: `buffer-substring-filters' is an obsolete
> variable (as of 24.1); use `filter-buffer-substring-functions' instead.
Yes. The fix is not trivial. Patch welcome!
Thanks,
--
Bastien
next prev parent reply other threads:[~2012-04-01 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 10:07 Org release 7.8.07 (BUGFIX-only release) Bastien
2012-03-31 13:22 ` Achim Gratz
2012-04-01 8:37 ` Bastien [this message]
2012-04-01 10:39 ` Achim Gratz
2012-04-02 19:53 ` Achim Gratz
2012-03-31 17:00 ` Eric Schulte
2012-03-31 17:05 ` Eric Schulte
2012-04-01 8:40 ` Bastien
2012-04-01 10:03 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehs7hmqb.fsf@gnu.org \
--to=bzg@gnu.org \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).