emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Error with org-agenda with 9.5.3
@ 2022-06-02 18:43 Robert Goldman
  2022-06-03  6:18 ` Ihor Radchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Robert Goldman @ 2022-06-02 18:43 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 1717 bytes --]

I just updated org-mode using package.el and got release 9.5.3

Now I get an error in `org-at-timestamp-p` (OATP), which is invoked when 
calling `org-agenda`.

I checked the repository and the problem is in commit 1f617727f1, which 
added to this function the following code block:

-  (let* ((regexp (if extended
-                     (if (eq extended 'agenda)
-                         org-element--timestamp-regexp
-		       org-ts-regexp3)
-                   org-ts-regexp2))
+  (let* ((regexp
+          (if extended
+              (if (eq extended 'agenda)
+                  (rx (or (regexp org-ts-regexp3)
+                          (regexp org-element--timestamp-regexp)))
+		org-ts-regexp3)
+            org-ts-regexp2))

The issue arises where OATP uses `rx` to process a regex stored in 

(rx (or (regexp org-ts-regexp3) ; here
         (regexp org-element--timestamp-regexp)))

This fails because `rx-check` checks the sub-expression `(regexp 
org-ts-regexp3)` to make sure that `org-ts-regexp3` is a string, but 
`org-ts-regexp3` is not evaluated, and the *symbol* `org-ts-regexp3` is 
not a string (it's a symbol), even though it's *value* is a string.

I'm not sure whether this is a bug in org-mode proper (I would have 
thought this would be caught before release) or perhaps org-mode expects 
some version of `rx.el` that I do not have.  Unfortunately, I don't see 
a version number in `rx.el`, only a copyright date.

I am running Emacs 25 (Aquamacs). So, maybe this code requires Emacs 26? 
If so, it would be nice if org-mode 9.5.3 was tagged as incompatible 
with Emacs 25? (It would also be nice if package mode supported 
roll-back, but that's OT here!)

[-- Attachment #2: Type: text/html, Size: 3690 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-06-04  6:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-02 18:43 Error with org-agenda with 9.5.3 Robert Goldman
2022-06-03  6:18 ` Ihor Radchenko
2022-06-03 14:08   ` Ihor Radchenko
2022-06-03 15:32     ` Robert Goldman
2022-06-04  6:42   ` Bastien Guerry

Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).