emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Footnote changes creates [REGRESSION] in xhtml/odt exporters
@ 2011-08-29  9:55 Jambunathan K
  2011-08-29 11:08 ` Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: Jambunathan K @ 2011-08-29  9:55 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]


Footnote changes creates [REGRESSION] in xhtml/odt exporters. The
required details are in the attached org file.

Caught by my test.org file :-).

-- 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: footnote-regression.org --]
[-- Type: text/x-org, Size: 2381 bytes --]

#+TITLE:     footnote-regression.org
#+AUTHOR:    
#+EMAIL:     kjambunathan@JAMBU-NETBOOK
#+DATE:      2011-08-29 Mon
#+DESCRIPTION:
#+KEYWORDS:
#+LANGUAGE:  en
#+OPTIONS:   H:3 num:t toc:t \n:nil @:t ::t |:t ^:t -:t f:t *:t <:t
#+OPTIONS:   TeX:t LaTeX:t skip:nil d:nil todo:t pri:nil tags:not-in-toc
#+INFOJS_OPT: view:nil toc:nil ltoc:t mouse:underline buttons:0 path:http://orgmode.org/org-info.js
#+EXPORT_SELECT_TAGS: export
#+EXPORT_EXCLUDE_TAGS: noexport
#+LINK_UP:   
#+LINK_HOME: 
#+XSLT:



* COMMENT Bug Description 

  With very minimal emacs, do
  1. M-x load-library RET org-html.el RET
  1. M-x load-library RET org-xhtml.el RET
  2. C-x C-f footnote-regression.org RET
  3. M-x org-export-as-xhtml-and-open RET
  4. Note that the title of this document ends up in the footnote
     definitions.

  Hint: I am seeing that the value returned by
  `org-export-preprocess-string' in the before and after commits are
  different.

* Second headline

  Duis aute irure dolor in reprehenderit in voluptate velit esse
  cillum dolore eu fugiat nulla pariatur[fn:inlabel:an inline
  footnote][fn:inlabel2:[[http://www.google.com][google]] this].

* COMMENT How Emacs is invoked

"C:\Program Files\emacs-24.0.50\bin\runemacs.exe" --debug-init -Q -L ~/src/org-mode/lisp -L ~/src/org-mode/contrib/lisp --visit footnote-regression.org"

* COMMENT  Commit that causes regression
git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[baf7dde28ef8730c558a6cf3c789d7400dbc51c6] org-footnote: allow non Org mode files to have no footnote tag

* COMMENT The good one

commit baf7dde28ef8730c558a6cf3c789d7400dbc51c6
Author: Nicolas Goaziou <n.goaziou@gmail.com>
Date:   Tue Aug 16 20:02:30 2011 +0200

    org-footnote: allow non Org mode files to have no footnote tag
    
    * lisp/org-footnote.el (org-footnote-tag-for-non-org-mode-files):
      notify the opportunity to set the variable to the empty string.
    (org-footnote-normalize, org-footnote-create-definition): carefully
      check for inserted newlines and presence of the footnote
      tag.

commit cb906e440661f102fd004cb7c8792c2498018858
Author: Nicolas Goaziou <n.goaziou@gmail.com>
Date:   Tue Aug 16 18:10:15 2011 +0200

    org-footnote: re-use global regexps when possible
    
    * lisp/org-footnote.el (org-footnote-at-definition-p): re-use
      org-footnote-definition-re.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Footnote changes creates [REGRESSION] in xhtml/odt exporters
  2011-08-29  9:55 Footnote changes creates [REGRESSION] in xhtml/odt exporters Jambunathan K
@ 2011-08-29 11:08 ` Nicolas Goaziou
  2011-08-29 11:55   ` Jambunathan K
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2011-08-29 11:08 UTC (permalink / raw)
  To: emacs-orgmode

Hello,

Jambunathan K <kjambunathan@gmail.com> writes:

> Footnote changes creates [REGRESSION] in xhtml/odt exporters. The
> required details are in the attached org file.
>
> Caught by my test.org file :-).

I've pushed a fix to master. Thanks for reporting it.

I have to admit I don't do xhtml/odt regression tests yet.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Footnote changes creates [REGRESSION] in xhtml/odt exporters
  2011-08-29 11:08 ` Nicolas Goaziou
@ 2011-08-29 11:55   ` Jambunathan K
  0 siblings, 0 replies; 3+ messages in thread
From: Jambunathan K @ 2011-08-29 11:55 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

Nicolas Goaziou <n.goaziou@gmail.com> writes:

> Hello,
>
> Jambunathan K <kjambunathan@gmail.com> writes:
>
>> Footnote changes creates [REGRESSION] in xhtml/odt exporters. The
>> required details are in the attached org file.
>>
>> Caught by my test.org file :-).
>
> I've pushed a fix to master. Thanks for reporting it.

Confirming that this is fixed.

> I have to admit I don't do xhtml/odt regression tests yet.

I didn't mean it that way.

In this context, I would like to re-surface Martyn Jago's offer of help
here.
http://lists.gnu.org/archive/html/emacs-orgmode/2011-07/msg00154.html

Jambunathan K.

>
> Regards,

-- 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-29 11:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-29  9:55 Footnote changes creates [REGRESSION] in xhtml/odt exporters Jambunathan K
2011-08-29 11:08 ` Nicolas Goaziou
2011-08-29 11:55   ` Jambunathan K

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).