From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jambunathan K Subject: Footnote changes creates [REGRESSION] in xhtml/odt exporters Date: Mon, 29 Aug 2011 15:25:27 +0530 Message-ID: <81d3fofsog.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([140.186.70.92]:40305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qxya4-0003Gb-6P for emacs-orgmode@gnu.org; Mon, 29 Aug 2011 05:56:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qxya2-0000Gr-NH for emacs-orgmode@gnu.org; Mon, 29 Aug 2011 05:56:36 -0400 Received: from mail-gx0-f169.google.com ([209.85.161.169]:54102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qxya2-0000Gj-Ij for emacs-orgmode@gnu.org; Mon, 29 Aug 2011 05:56:34 -0400 Received: by gxk23 with SMTP id 23so4924483gxk.0 for ; Mon, 29 Aug 2011 02:56:33 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Footnote changes creates [REGRESSION] in xhtml/odt exporters. The required details are in the attached org file. Caught by my test.org file :-). -- --=-=-= Content-Type: text/x-org Content-Disposition: attachment; filename=footnote-regression.org #+TITLE: footnote-regression.org #+AUTHOR: #+EMAIL: kjambunathan@JAMBU-NETBOOK #+DATE: 2011-08-29 Mon #+DESCRIPTION: #+KEYWORDS: #+LANGUAGE: en #+OPTIONS: H:3 num:t toc:t \n:nil @:t ::t |:t ^:t -:t f:t *:t <:t #+OPTIONS: TeX:t LaTeX:t skip:nil d:nil todo:t pri:nil tags:not-in-toc #+INFOJS_OPT: view:nil toc:nil ltoc:t mouse:underline buttons:0 path:http://orgmode.org/org-info.js #+EXPORT_SELECT_TAGS: export #+EXPORT_EXCLUDE_TAGS: noexport #+LINK_UP: #+LINK_HOME: #+XSLT: * COMMENT Bug Description With very minimal emacs, do 1. M-x load-library RET org-html.el RET 1. M-x load-library RET org-xhtml.el RET 2. C-x C-f footnote-regression.org RET 3. M-x org-export-as-xhtml-and-open RET 4. Note that the title of this document ends up in the footnote definitions. Hint: I am seeing that the value returned by `org-export-preprocess-string' in the before and after commits are different. * Second headline Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur[fn:inlabel:an inline footnote][fn:inlabel2:[[http://www.google.com][google]] this]. * COMMENT How Emacs is invoked "C:\Program Files\emacs-24.0.50\bin\runemacs.exe" --debug-init -Q -L ~/src/org-mode/lisp -L ~/src/org-mode/contrib/lisp --visit footnote-regression.org" * COMMENT Commit that causes regression git bisect bad Bisecting: 0 revisions left to test after this (roughly 0 steps) [baf7dde28ef8730c558a6cf3c789d7400dbc51c6] org-footnote: allow non Org mode files to have no footnote tag * COMMENT The good one commit baf7dde28ef8730c558a6cf3c789d7400dbc51c6 Author: Nicolas Goaziou Date: Tue Aug 16 20:02:30 2011 +0200 org-footnote: allow non Org mode files to have no footnote tag * lisp/org-footnote.el (org-footnote-tag-for-non-org-mode-files): notify the opportunity to set the variable to the empty string. (org-footnote-normalize, org-footnote-create-definition): carefully check for inserted newlines and presence of the footnote tag. commit cb906e440661f102fd004cb7c8792c2498018858 Author: Nicolas Goaziou Date: Tue Aug 16 18:10:15 2011 +0200 org-footnote: re-use global regexps when possible * lisp/org-footnote.el (org-footnote-at-definition-p): re-use org-footnote-definition-re. --=-=-=--