From: Nick Dokos <email@example.com> To: Le Wang <firstname.lastname@example.org> Cc: email@example.com, Orgmode Mailing List <firstname.lastname@example.org>, Carsten Dominik <email@example.com> Subject: Re: `session-jump-to-last-change' and org-mode Date: Thu, 17 Mar 2011 10:27:50 -0400 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: Message from Le Wang <email@example.com> of "Thu\, 17 Mar 2011 16\:53\:21 +0800." <AANLkTinQ0w16zNct5xZPU-rQ1A9D+hd5xoZ-uR5b_S6d@mail.gmail.com> Le Wang <firstname.lastname@example.org> wrote: > On Thu, Mar 17, 2011 at 3:02 PM, Carsten Dominik <email@example.com> wrote: > > (defadvice session-jump-to-last-change (after org-expand activate compile) > "Reveal hidden point after jumping." > (when (and (eq major-mode 'org-mode) > (outline-invisible-p)) > (org-reveal))) > > Thanks Carsten! That's xactly what I wanted. I'll coordinate with session's author to get this > change integrated. > Why would you need to coordinate with the session author about advising a function? It's your own personal advice and you can do whatever you want. Of course, as Carsten pointed out, there is good advice and there is bad advice, and you should only give good advice. But you are not requesting any changes to the session code. You just stick the advice in your .emacs and that's that. Am I missing something? Nick
next prev parent reply other threads:[~2011-03-17 14:28 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-03-16 15:18 Le Wang 2011-03-16 16:13 ` Samuel Wales 2011-03-16 16:27 ` Le Wang 2011-03-17 6:20 ` Le Wang 2011-03-17 7:02 ` Carsten Dominik 2011-03-17 8:53 ` Le Wang 2011-03-17 14:27 ` Nick Dokos [this message] 2011-03-17 14:54 ` Le Wang 2011-03-17 18:30 ` Eric S Fraga 2011-03-17 20:13 ` Carsten Dominik 2011-04-13 1:59 ` Le Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: `session-jump-to-last-change'\'' and org-mode' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).