From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Dokos <nicholas.dokos@hp.com>
Subject: Re: `session-jump-to-last-change' and org-mode
Date: Thu, 17 Mar 2011 10:27:50 -0400
Message-ID: <8120.1300372070@alphaville.dokosmarshall.org>
References: <AANLkTin-78sNfR0st-YW9623ON_TJSZ9kAmQKV+noa9w@mail.gmail.com>
	<AANLkTimrSpM_fhRLfQ7PUKSikeXYvzW_X07CR-7=oHi1@mail.gmail.com>
	<AANLkTim74_OrbApRbfi4_F4vL3hATGD-5s+kHVOwK6iq@mail.gmail.com>
	<AANLkTi=Zf0JwWx7uMYc57iqm0Q+5VoU_rzGgGSfVcvBy@mail.gmail.com>
	<B95E706E-A403-4897-8225-BC979BDD65DB@gmail.com>
	<AANLkTinQ0w16zNct5xZPU-rQ1A9D+hd5xoZ-uR5b_S6d@mail.gmail.com>
Reply-To: nicholas.dokos@hp.com
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=57499 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q0EBX-0000EF-IG
	for emacs-orgmode@gnu.org; Thu, 17 Mar 2011 10:28:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nick@dokosmarshall.org>) id 1Q0EBW-0002Ax-Hf
	for emacs-orgmode@gnu.org; Thu, 17 Mar 2011 10:28:19 -0400
Received: from vms173005pub.verizon.net ([206.46.173.5]:38130)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nick@dokosmarshall.org>) id 1Q0EBW-0002Ap-9m
	for emacs-orgmode@gnu.org; Thu, 17 Mar 2011 10:28:18 -0400
Received: from alphaville.dokosmarshall.org ([unknown] [173.76.32.106])
	by vms173005.mailsrvcs.net
	(Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16
	2009)) with ESMTPA id <0LI700LLPHIFXE10@vms173005.mailsrvcs.net> for
	emacs-orgmode@gnu.org; Thu, 17 Mar 2011 09:27:57 -0500 (CDT)
In-reply-to: Message from Le Wang <l26wang@gmail.com> of
	"Thu\, 17 Mar 2011 16\:53\:21 +0800."
	<AANLkTinQ0w16zNct5xZPU-rQ1A9D+hd5xoZ-uR5b_S6d@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Le Wang <l26wang@gmail.com>
Cc: nicholas.dokos@hp.com, Orgmode Mailing List <emacs-orgmode@gnu.org>, Carsten Dominik <carsten.dominik@gmail.com>

Le Wang <l26wang@gmail.com> wrote:

> On Thu, Mar 17, 2011 at 3:02 PM, Carsten Dominik <carsten.dominik@gmail.c=
om> wrote:
>=20
>     (defadvice session-jump-to-last-change (after org-expand activate com=
pile)
>     =C2=A0"Reveal hidden point after jumping."
>     =C2=A0(when (and (eq major-mode 'org-mode)
>     =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (outline-invisible-p))
>     =C2=A0 =C2=A0(org-reveal)))
>=20
> Thanks Carsten!=C2=A0 That's xactly what I wanted.=C2=A0 I'll coordinate =
with session's author to get this
> change integrated.
>=20

Why would you need to coordinate with the session author about advising
a function? It's your own personal advice and you can do whatever you
want. Of course, as Carsten pointed out, there is good advice and there
is bad advice, and you should only give good advice. But you are not
requesting any changes to the session code. You just stick the advice in
your .emacs and that's that.

Am I missing something?
Nick