From: Carsten Dominik <carsten.dominik@gmail.com>
To: Eric S Fraga <e.fraga@ucl.ac.uk>
Cc: nicholas.dokos@hp.com,
Orgmode Mailing List <emacs-orgmode@gnu.org>,
Le Wang <l26wang@gmail.com>
Subject: Re: `session-jump-to-last-change' and org-mode
Date: Thu, 17 Mar 2011 21:13:46 +0100 [thread overview]
Message-ID: <F7DA7E3D-D09C-48B7-B734-BDA265852F3E@gmail.com> (raw)
In-Reply-To: <87ei65ioq2.fsf@ucl.ac.uk>
On 17.3.2011, at 19:30, Eric S Fraga wrote:
> Le Wang <l26wang@gmail.com> writes:
>
>> On Thu, Mar 17, 2011 at 10:27 PM, Nick Dokos <nicholas.dokos@hp.com> wrote:
>>
>>> Why would you need to coordinate with the session author about advising
>>> a function? It's your own personal advice and you can do whatever you
>>> want. Of course, as Carsten pointed out, there is good advice and there
>>> is bad advice, and you should only give good advice. But you are not
>>> requesting any changes to the session code. You just stick the advice in
>>> your .emacs and that's that.
>>>
>>> Am I missing something?
>>
>>
>> The defadvice is a hack until session can be changed to not need it. I
>> assume I won't be the only one to ever find this useful.
>
> Sure but I don't think it makes sense to customise the behaviour of
> /session/ for /org/ specific issues? The session code should be kept as
> general as possible, I would suggest.
A good solution would be for session to provide a hook that we can use.
- Carsten
>
> --
> : Eric S Fraga (GnuPG: 0xC89193D8FFFCF67D) in Emacs 24.0.50.1
> : using Org-mode version 7.5 (release_7.5.77.g74268.dirty)
>
next prev parent reply other threads:[~2011-03-17 20:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 15:18 `session-jump-to-last-change' and org-mode Le Wang
2011-03-16 16:13 ` Samuel Wales
2011-03-16 16:27 ` Le Wang
2011-03-17 6:20 ` Le Wang
2011-03-17 7:02 ` Carsten Dominik
2011-03-17 8:53 ` Le Wang
2011-03-17 14:27 ` Nick Dokos
2011-03-17 14:54 ` Le Wang
2011-03-17 18:30 ` Eric S Fraga
2011-03-17 20:13 ` Carsten Dominik [this message]
2011-04-13 1:59 ` Le Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F7DA7E3D-D09C-48B7-B734-BDA265852F3E@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=e.fraga@ucl.ac.uk \
--cc=emacs-orgmode@gnu.org \
--cc=l26wang@gmail.com \
--cc=nicholas.dokos@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).