From: Carsten Dominik <carsten.dominik@gmail.com>
To: Sebastien Vauban <sva-news@mygooglest.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] in Release 8.2 - editing code in indirect buffer
Date: Tue, 24 Sep 2013 18:35:22 +0200 [thread overview]
Message-ID: <578DF849-8046-47A6-879C-FC5874BE591B@gmail.com> (raw)
In-Reply-To: <86zjr2urcg.fsf@somewhere.org>
[-- Attachment #1: Type: text/plain, Size: 2287 bytes --]
On 24.9.2013, at 18:17, Sebastien Vauban <sva-news@mygooglest.com> wrote:
> Hello Carsten,
>
> Carsten Dominik wrote:
>> On 23.9.2013, at 09:40, Rainer M Krug <Rainer@krugs.de> wrote:
>>>
>>> When starting to edit a code block via C-c ' everything works as expected
>>> and the code block is highlighted and an indirect buffer is opened.
>>>
>>> When I click into the highlighted block, I an "send" to the indirect buffer.
>>> This behavior changes, after saving with C-s, even when nothing has been
>>> edited: the area in the original org file looses its magic, and looks normal
>>> again and can also be edited!
>>>
>>> The indirect buffer stays functional and, upon close via C-c ' saves the
>>> changes into the original buffer and *overwrites* changes done in this block
>>> in the org document.
>>
>> This is a bug which is difficult to fix in all generality. What should really
>> happen is that the text in the original buffer is made read-only. But so far
>> this does not happen in our implementation (due to Dan Davison IIRC). The
>> reason for this is that read-only text properties left by accident in a
>> buffer are difficult to get rid of.
>>
>> There are many things the user could go back and screw up the original.
>> That's why Org choses to protect with highlighting with an overlay. Note that
>> this is not a protection against editing, but it is a visual warning.
>
> I never knew that "your" goal was to make the code block read-only in the Org
> buffer. Note that I would be really opposed to such a change. Editing code in
> the prose would really become a pain to me -- please know that I NEVER use the
> indirect buffer.
Hi Sebastian,
I only mean while there is a special buffer also editing this block!
- Carsten
>
> I hope that we will block such a functionality, would the read-only feature
> become possible.
>
>> However, what happens during saving is indeed a problem - the overlay gets
>> lost (not really, it gets squeezed to zero by first removing the source code
>> and then inserting the modified version).
>>
>> Could you please try this patch and test it to see if it is stable and does
>> the right thing?
>
> Best regards,
> Seb
>
> --
> Sebastien Vauban
>
>
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2013-09-24 16:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 20:27 Release 8.2 Carsten Dominik
2013-09-20 4:32 ` Mehul Sanghvi
2013-09-20 5:07 ` Carsten Dominik
2013-09-20 9:40 ` Alexander Baier
2013-09-20 10:01 ` Carsten Dominik
2013-09-20 11:06 ` BUG?: BABEL - " Rainer M Krug
2013-09-20 11:06 ` Rainer M Krug
2013-09-21 13:54 ` Rainer M Krug
2013-09-21 15:02 ` BUG?: Org-src " Eric Schulte
2013-09-21 15:25 ` BUG?: BABEL " Ista Zahn
2013-09-20 11:17 ` Suvayu Ali
2013-09-23 7:40 ` [BUG] in Release 8.2 - editing code in indirect buffer Rainer M Krug
2013-09-24 14:01 ` Rainer M Krug
2013-09-24 16:02 ` Carsten Dominik
2013-09-24 16:17 ` Sebastien Vauban
2013-09-24 16:35 ` Carsten Dominik [this message]
[not found] ` <578DF849-8046-47A6-879C-FC5874BE591B-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-24 16:53 ` Sebastien Vauban
2013-09-25 6:53 ` Rainer M Krug
2013-09-25 7:09 ` Carsten Dominik
2013-09-25 7:38 ` Rainer M Krug
2013-09-25 13:13 ` Eric Schulte
2013-09-25 14:00 ` Rainer M Krug
2013-09-25 19:39 ` Andreas Leha
2013-09-26 8:11 ` Rainer M Krug
2013-09-25 6:48 ` Rainer M Krug
2013-09-25 7:15 ` Carsten Dominik
2013-09-25 7:29 ` Rainer M Krug
2013-10-02 22:55 ` Release 8.2 Mike McLean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578DF849-8046-47A6-879C-FC5874BE591B@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=sva-news@mygooglest.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).