emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Richard Hansen <rhansen@bbn.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] fix SETUPFILE pathname expansion with subdirectories
Date: Sat, 19 Sep 2015 19:14:03 -0400	[thread overview]
Message-ID: <55FDEC3B.2080805@bbn.com> (raw)
In-Reply-To: <87twqq3u97.fsf@kyleam.com>

On 2015-09-19 18:43, Kyle Meyer wrote:
> Richard Hansen <rhansen@bbn.com> writes:
> 
>>  			     (with-temp-buffer
>> +			       (cd (file-name-directory file))
>>  			       (org-mode)
>>  			       (insert (org-file-contents file 'noerror))
> 
> Why not just set default-directory instead of calling cd?  Does it make
> sense to support CDPATH here?

I wasn't aware of CDPATH and its interaction with cd.  Should I use
cd-absolute instead of setting default-directory directly?  It does some
sanity checks (among other things) that seem worthwhile.

Thanks,
Richard

next prev parent reply	other threads:[~2015-09-19 23:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-19  0:22 [PATCH] fix SETUPFILE pathname expansion with subdirectories Richard Hansen
2015-09-19  8:16 ` Nicolas Goaziou
2015-09-19 20:18   ` Richard Hansen
2015-09-19 22:07   ` [PATCH v2] " Richard Hansen
2015-09-19 22:43     ` Kyle Meyer
2015-09-19 23:14       ` Richard Hansen [this message]
2015-09-20  5:07         ` Kyle Meyer
2015-09-20  5:28           ` [PATCH v3] " Richard Hansen
2015-09-22 22:28             ` Richard Hansen
2015-09-24  8:22               ` Nicolas Goaziou
2015-09-24 21:55                 ` Richard Hansen
2015-09-24 22:20                   ` [PATCH 1/2] test INCLUDE " Richard Hansen
2015-09-24 22:20                     ` [PATCH 2/2] fix SETUPFILE pathname expansion from within an INCLUDE Richard Hansen
2015-09-25 11:58                       ` Nicolas Goaziou
2015-09-25 11:51                   ` [PATCH v3] fix SETUPFILE pathname expansion with subdirectories Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55FDEC3B.2080805@bbn.com \
    --to=rhansen@bbn.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).