From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Hansen Subject: Re: [PATCH v2] fix SETUPFILE pathname expansion with subdirectories Date: Sat, 19 Sep 2015 19:14:03 -0400 Message-ID: <55FDEC3B.2080805@bbn.com> References: <87lhc2u8ln.fsf@nicolasgoaziou.fr> <1442700472-3845-1-git-send-email-rhansen@bbn.com> <87twqq3u97.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdRKd-0001uo-3O for emacs-orgmode@gnu.org; Sat, 19 Sep 2015 19:14:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZdRKY-00051r-5I for emacs-orgmode@gnu.org; Sat, 19 Sep 2015 19:14:11 -0400 Received: from smtp.bbn.com ([128.33.0.80]:15875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdRKY-00051f-1s for emacs-orgmode@gnu.org; Sat, 19 Sep 2015 19:14:06 -0400 In-Reply-To: <87twqq3u97.fsf@kyleam.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Kyle Meyer Cc: emacs-orgmode@gnu.org On 2015-09-19 18:43, Kyle Meyer wrote: > Richard Hansen writes: >=20 >> (with-temp-buffer >> + (cd (file-name-directory file)) >> (org-mode) >> (insert (org-file-contents file 'noerror)) >=20 > Why not just set default-directory instead of calling cd? Does it make > sense to support CDPATH here? I wasn't aware of CDPATH and its interaction with cd. Should I use cd-absolute instead of setting default-directory directly? It does some sanity checks (among other things) that seem worthwhile. Thanks, Richard