From: Kyle Meyer <kyle@kyleam.com>
To: Richard Hansen <rhansen@bbn.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] fix SETUPFILE pathname expansion with subdirectories
Date: Sun, 20 Sep 2015 01:07:37 -0400 [thread overview]
Message-ID: <87bncxhe5i.fsf@kyleam.com> (raw)
In-Reply-To: 55FDEC3B.2080805@bbn.com
Richard Hansen <rhansen@bbn.com> writes:
> Should I use cd-absolute instead of setting default-directory
> directly? It does some sanity checks (among other things) that seem
> worthwhile.
Looking at these checks, I don't think they are useful in this context,
and some change the intended behavior.
* One check makes sure the directory ends in a slash, but this will
already be the case because your changes call file-name-directory.
* Another calls expand-file-name, but all these functions already expand
the original file name upstream.
* Another signals an error if the directory doesn't exist, is not a
directory, or isn't accessible. All but one of these functions call
org-file-contents with a non-nil NOERROR, so the intent is to message
rather than raise an error when a file doesn't exist.
(org--setup-collect-keywords is the one function that doesn't use
org-file-contents, but it does check that the file is readable before
calling insert-file-contents.)
--
Kyle
next prev parent reply other threads:[~2015-09-20 5:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 0:22 [PATCH] fix SETUPFILE pathname expansion with subdirectories Richard Hansen
2015-09-19 8:16 ` Nicolas Goaziou
2015-09-19 20:18 ` Richard Hansen
2015-09-19 22:07 ` [PATCH v2] " Richard Hansen
2015-09-19 22:43 ` Kyle Meyer
2015-09-19 23:14 ` Richard Hansen
2015-09-20 5:07 ` Kyle Meyer [this message]
2015-09-20 5:28 ` [PATCH v3] " Richard Hansen
2015-09-22 22:28 ` Richard Hansen
2015-09-24 8:22 ` Nicolas Goaziou
2015-09-24 21:55 ` Richard Hansen
2015-09-24 22:20 ` [PATCH 1/2] test INCLUDE " Richard Hansen
2015-09-24 22:20 ` [PATCH 2/2] fix SETUPFILE pathname expansion from within an INCLUDE Richard Hansen
2015-09-25 11:58 ` Nicolas Goaziou
2015-09-25 11:51 ` [PATCH v3] fix SETUPFILE pathname expansion with subdirectories Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bncxhe5i.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=rhansen@bbn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).