* Bug: org-archive-subtree-add-inherited-tags should use both local and inherited tags [9.1.12 (9.1.12-elpa @ ~/.emacs.d/elpa/org-9.1.12/)]
@ 2018-05-04 13:20 email
2018-05-04 21:36 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: email @ 2018-05-04 13:20 UTC (permalink / raw)
To: emacs-orgmode
Greetings fellow org-mode enthusiasts,
I discovered that in the latest org-mode setting
(org-archive-subtree-add-inherited-tags t) only includes inherited tags
but omits local tags.
To remedy this I propose the following patch to org-archive.el:
diff --git a/org-archive.el b/org-archive.el
index e020ec2..0ac164d 100644
--- a/org-archive.el
+++ b/org-archive.el
@@ -361,7 +361,7 @@ direct children of this heading."
(or (and (eq org-archive-subtree-add-inherited-tags
'infile)
infile-p)
(eq org-archive-subtree-add-inherited-tags t))
- (org-set-tags-to all-tags))
+ (org-set-tags-to (delete-dups (append inherited-tags
local-tags))))
;; Mark the entry as done
(when (and org-archive-mark-done
(let ((case-fold-search nil))
However, I am not sure if this is enough or if something more fundamental
is broken since all-tags only includes inherited tags and not actually all
tags.
Best regards,
Edgar Kalkowski
Emacs : GNU Emacs 25.3.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.26)
of 2018-02-09
Package: Org mode version 9.1.12 (9.1.12-elpa @ ~/.emacs.d/elpa/org-9.1.12/)
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-04 21:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-04 13:20 Bug: org-archive-subtree-add-inherited-tags should use both local and inherited tags [9.1.12 (9.1.12-elpa @ ~/.emacs.d/elpa/org-9.1.12/)] email
2018-05-04 21:36 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).