emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: email@edgar-kalkowski.de
To: emacs-orgmode@gnu.org
Subject: Bug: org-archive-subtree-add-inherited-tags should use both local and inherited tags [9.1.12 (9.1.12-elpa @ ~/.emacs.d/elpa/org-9.1.12/)]
Date: Fri, 4 May 2018 15:20:06 +0200	[thread overview]
Message-ID: <4b268df4db51ce0e117974ae1597c0b4.squirrel@edgar-kalkowski.de> (raw)

Greetings fellow org-mode enthusiasts,

I discovered that in the latest org-mode setting
(org-archive-subtree-add-inherited-tags t) only includes inherited tags
but omits local tags.

To remedy this I propose the following patch to org-archive.el:


diff --git a/org-archive.el b/org-archive.el
index e020ec2..0ac164d 100644
--- a/org-archive.el
+++ b/org-archive.el
@@ -361,7 +361,7 @@ direct children of this heading."
                   (or (and (eq org-archive-subtree-add-inherited-tags
'infile)
                            infile-p)
                       (eq org-archive-subtree-add-inherited-tags t))
-                  (org-set-tags-to all-tags))
+                  (org-set-tags-to (delete-dups (append inherited-tags
local-tags))))
              ;; Mark the entry as done
              (when (and org-archive-mark-done
                         (let ((case-fold-search nil))


However, I am not sure if this is enough or if something more fundamental
is broken since all-tags only includes inherited tags and not actually all
tags.

Best regards,

Edgar Kalkowski


Emacs  : GNU Emacs 25.3.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.26)
 of 2018-02-09
Package: Org mode version 9.1.12 (9.1.12-elpa @ ~/.emacs.d/elpa/org-9.1.12/)

next             reply	other threads:[~2018-05-04 13:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 13:20 email [this message]
2018-05-04 21:36 ` Bug: org-archive-subtree-add-inherited-tags should use both local and inherited tags [9.1.12 (9.1.12-elpa @ ~/.emacs.d/elpa/org-9.1.12/)] Nicolas Goaziou

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:e020ec2 dfblob:0ac164d
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b268df4db51ce0e117974ae1597c0b4.squirrel@edgar-kalkowski.de \
    --to=email@edgar-kalkowski.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).