emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] org-scan-tags: remove useless variable
@ 2010-12-21 16:00 Julien Danjou
  2010-12-23  7:27 ` Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: Julien Danjou @ 2010-12-21 16:00 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Julien Danjou

* lisp/org.el (org-scan-tags): remove useless todo variable.

Signed-off-by: Julien Danjou <julien@danjou.info>
---
 lisp/org.el |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 3cecca7..85898ab 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12198,7 +12198,7 @@ only lines with a TODO keyword are included in the output."
          lspos tags tags-list
 	 (tags-alist (list (cons 0 org-file-tags)))
 	 (llast 0) rtn rtn1 level category i txt
-	 todo marker entry priority)
+	 marker entry priority)
     (when (not (or (member action '(agenda sparse-tree)) (functionp action)))
       (setq action (list 'lambda nil action)))
     (save-excursion
@@ -12208,8 +12208,7 @@ only lines with a TODO keyword are included in the output."
 	(org-remove-occur-highlights))
       (while (re-search-forward re nil t)
 	(catch :skip
-	  (setq todo (if (match-end 1) (org-match-string-no-properties 2))
-		tags (if (match-end 4) (org-match-string-no-properties 4)))
+	  (setq tags (if (match-end 4) (org-match-string-no-properties 4)))
 	  (goto-char (setq lspos (match-beginning 0)))
 	  (setq level (org-reduced-level (funcall outline-level))
 		category (org-get-category))
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] org-scan-tags: remove useless variable
  2010-12-21 16:00 [PATCH] org-scan-tags: remove useless variable Julien Danjou
@ 2010-12-23  7:27 ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2010-12-23  7:27 UTC (permalink / raw)
  To: Julien Danjou; +Cc: emacs-orgmode

Rejected - the todo variable is used further down in the funtion.

- Carsten

On Dec 21, 2010, at 5:00 PM, Julien Danjou wrote:

> * lisp/org.el (org-scan-tags): remove useless todo variable.
>
> Signed-off-by: Julien Danjou <julien@danjou.info>
> ---
> lisp/org.el |    5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 3cecca7..85898ab 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -12198,7 +12198,7 @@ only lines with a TODO keyword are included  
> in the output."
>          lspos tags tags-list
> 	 (tags-alist (list (cons 0 org-file-tags)))
> 	 (llast 0) rtn rtn1 level category i txt
> -	 todo marker entry priority)
> +	 marker entry priority)
>     (when (not (or (member action '(agenda sparse-tree)) (functionp  
> action)))
>       (setq action (list 'lambda nil action)))
>     (save-excursion
> @@ -12208,8 +12208,7 @@ only lines with a TODO keyword are included  
> in the output."
> 	(org-remove-occur-highlights))
>       (while (re-search-forward re nil t)
> 	(catch :skip
> -	  (setq todo (if (match-end 1) (org-match-string-no-properties 2))
> -		tags (if (match-end 4) (org-match-string-no-properties 4)))
> +	  (setq tags (if (match-end 4) (org-match-string-no-properties 4)))
> 	  (goto-char (setq lspos (match-beginning 0)))
> 	  (setq level (org-reduced-level (funcall outline-level))
> 		category (org-get-category))
> -- 
> 1.7.2.3
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-12-23  7:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-21 16:00 [PATCH] org-scan-tags: remove useless variable Julien Danjou
2010-12-23  7:27 ` Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).