From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] org-scan-tags: remove useless variable Date: Thu, 23 Dec 2010 08:27:03 +0100 Message-ID: <46CC7D06-DBF0-4531-8A12-C1458AFD69DA@gmail.com> References: <1292947223-13884-1-git-send-email-julien@danjou.info> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=49335 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PVfZv-0005fr-RD for emacs-orgmode@gnu.org; Thu, 23 Dec 2010 02:27:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PVfZu-0002Vb-Jh for emacs-orgmode@gnu.org; Thu, 23 Dec 2010 02:27:11 -0500 Received: from mail-bw0-f41.google.com ([209.85.214.41]:47230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PVfZu-0002VO-Br for emacs-orgmode@gnu.org; Thu, 23 Dec 2010 02:27:10 -0500 Received: by bwz16 with SMTP id 16so10012795bwz.0 for ; Wed, 22 Dec 2010 23:27:08 -0800 (PST) In-Reply-To: <1292947223-13884-1-git-send-email-julien@danjou.info> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Julien Danjou Cc: emacs-orgmode@gnu.org Rejected - the todo variable is used further down in the funtion. - Carsten On Dec 21, 2010, at 5:00 PM, Julien Danjou wrote: > * lisp/org.el (org-scan-tags): remove useless todo variable. > > Signed-off-by: Julien Danjou > --- > lisp/org.el | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lisp/org.el b/lisp/org.el > index 3cecca7..85898ab 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -12198,7 +12198,7 @@ only lines with a TODO keyword are included > in the output." > lspos tags tags-list > (tags-alist (list (cons 0 org-file-tags))) > (llast 0) rtn rtn1 level category i txt > - todo marker entry priority) > + marker entry priority) > (when (not (or (member action '(agenda sparse-tree)) (functionp > action))) > (setq action (list 'lambda nil action))) > (save-excursion > @@ -12208,8 +12208,7 @@ only lines with a TODO keyword are included > in the output." > (org-remove-occur-highlights)) > (while (re-search-forward re nil t) > (catch :skip > - (setq todo (if (match-end 1) (org-match-string-no-properties 2)) > - tags (if (match-end 4) (org-match-string-no-properties 4))) > + (setq tags (if (match-end 4) (org-match-string-no-properties 4))) > (goto-char (setq lspos (match-beginning 0))) > (setq level (org-reduced-level (funcall outline-level)) > category (org-get-category)) > -- > 1.7.2.3 > > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode