From: Carsten Dominik <carsten.dominik@gmail.com>
To: Julien Danjou <julien@danjou.info>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-scan-tags: remove useless variable
Date: Thu, 23 Dec 2010 08:27:03 +0100 [thread overview]
Message-ID: <46CC7D06-DBF0-4531-8A12-C1458AFD69DA@gmail.com> (raw)
In-Reply-To: <1292947223-13884-1-git-send-email-julien@danjou.info>
Rejected - the todo variable is used further down in the funtion.
- Carsten
On Dec 21, 2010, at 5:00 PM, Julien Danjou wrote:
> * lisp/org.el (org-scan-tags): remove useless todo variable.
>
> Signed-off-by: Julien Danjou <julien@danjou.info>
> ---
> lisp/org.el | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 3cecca7..85898ab 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -12198,7 +12198,7 @@ only lines with a TODO keyword are included
> in the output."
> lspos tags tags-list
> (tags-alist (list (cons 0 org-file-tags)))
> (llast 0) rtn rtn1 level category i txt
> - todo marker entry priority)
> + marker entry priority)
> (when (not (or (member action '(agenda sparse-tree)) (functionp
> action)))
> (setq action (list 'lambda nil action)))
> (save-excursion
> @@ -12208,8 +12208,7 @@ only lines with a TODO keyword are included
> in the output."
> (org-remove-occur-highlights))
> (while (re-search-forward re nil t)
> (catch :skip
> - (setq todo (if (match-end 1) (org-match-string-no-properties 2))
> - tags (if (match-end 4) (org-match-string-no-properties 4)))
> + (setq tags (if (match-end 4) (org-match-string-no-properties 4)))
> (goto-char (setq lspos (match-beginning 0)))
> (setq level (org-reduced-level (funcall outline-level))
> category (org-get-category))
> --
> 1.7.2.3
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
prev parent reply other threads:[~2010-12-23 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 16:00 [PATCH] org-scan-tags: remove useless variable Julien Danjou
2010-12-23 7:27 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CC7D06-DBF0-4531-8A12-C1458AFD69DA@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=julien@danjou.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).