[PATCH] Revert "Jump to selected clock task when starting the clock"

* [PATCH] Revert "Jump to selected clock task when starting the clock"
@ 2009-04-21  2:37 Bernt Hansen
  2009-04-21  2:37 ` [PATCH] Add NOBLOCKING to org-default-properties Bernt Hansen
  2009-04-21  7:45 ` [PATCH] Revert "Jump to selected clock task when starting the clock" Carsten Dominik
  0 siblings, 2 replies; 4+ messages in thread
From: Bernt Hansen @ 2009-04-21  2:37 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Bernt Hansen

This reverts commit 61dfa0c67fcb47351f2139160ad7f59d7e742254.

This wasn't such a great idea after all.  There is one case where
this is really annoying - if you are in the middle of displaying
an agenda view with lots of filters active and you change what you
are clocking it jumps away you lose the agenda view.

This one case makes hitting a dedicated function key that runs
org-clock-goto more desireable.
---
I should have sat on that original patch for a week longer before posting it :/
When doing my weekly review today I ran into a case where I wanted to change
the clocked task in the middle of reviewing all my outstanding tasks.  This jumped
to the task and I lost my place in the middle of my (huge) task list.

This patch is available at git://git.norang.ca/org-mode.git for-carsten

 lisp/org-clock.el |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 21f298d..0d51275 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -380,8 +380,7 @@ the clocking selection, associated with the letter `d'."
 	    (org-clock-update-mode-line)
 	    (setq org-clock-mode-line-timer
 		  (run-with-timer 60 60 'org-clock-update-mode-line))
-	    (message "Clock started at %s" ts)))))
-    (org-clock-goto nil)))
+	    (message "Clock started at %s" ts)))))))
 
 (defun org-clock-find-position (find-unclosed)
   "Find the location where the next clock line should be inserted.
-- 
1.6.3.rc1

^ permalink raw reply related	[flat|nested] 4+ messages in thread