emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bernt Hansen <bernt@norang.ca>
To: emacs-orgmode@gnu.org
Cc: Bernt Hansen <bernt@norang.ca>
Subject: [PATCH] Revert "Jump to selected clock task when starting the clock"
Date: Mon, 20 Apr 2009 22:37:46 -0400	[thread overview]
Message-ID: <1240281467-15562-1-git-send-email-bernt@norang.ca> (raw)

This reverts commit 61dfa0c67fcb47351f2139160ad7f59d7e742254.

This wasn't such a great idea after all.  There is one case where
this is really annoying - if you are in the middle of displaying
an agenda view with lots of filters active and you change what you
are clocking it jumps away you lose the agenda view.

This one case makes hitting a dedicated function key that runs
org-clock-goto more desireable.
---
I should have sat on that original patch for a week longer before posting it :/
When doing my weekly review today I ran into a case where I wanted to change
the clocked task in the middle of reviewing all my outstanding tasks.  This jumped
to the task and I lost my place in the middle of my (huge) task list.

This patch is available at git://git.norang.ca/org-mode.git for-carsten

 lisp/org-clock.el |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 21f298d..0d51275 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -380,8 +380,7 @@ the clocking selection, associated with the letter `d'."
 	    (org-clock-update-mode-line)
 	    (setq org-clock-mode-line-timer
 		  (run-with-timer 60 60 'org-clock-update-mode-line))
-	    (message "Clock started at %s" ts)))))
-    (org-clock-goto nil)))
+	    (message "Clock started at %s" ts)))))))
 
 (defun org-clock-find-position (find-unclosed)
   "Find the location where the next clock line should be inserted.
-- 
1.6.3.rc1

next             reply	other threads:[~2009-04-21  2:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-21  2:37 Bernt Hansen [this message]
2009-04-21  2:37 ` [PATCH] Add NOBLOCKING to org-default-properties Bernt Hansen
2009-04-21  7:45   ` Carsten Dominik
2009-04-21  7:45 ` [PATCH] Revert "Jump to selected clock task when starting the clock" Carsten Dominik

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:21f298d dfblob:0d51275
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240281467-15562-1-git-send-email-bernt@norang.ca \
    --to=bernt@norang.ca \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).