* [BUG] Hard lockup on org-display-inline-images
@ 2023-12-03 23:20 JD Smith
2023-12-05 12:26 ` Ihor Radchenko
0 siblings, 1 reply; 4+ messages in thread
From: JD Smith @ 2023-12-03 23:20 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
Eli and I recently patched a problem <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67533> with pixel position reporting with inline images (which I had discovered in a large org buffer with latex-preview). With this patch installed, now on master as of this evening, org-display-inline-images freezes emacs when a larger image is included in an org file, if org-indent is enabled.
I’ve confirmed such images are fine in regular buffers by text-property or overlay, so I suspect this is a “revealed bug” in org-indent or the element cache.
Org 9.6.11
Thanks for your work on org!
[-- Attachment #2: Type: text/html, Size: 908 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] Hard lockup on org-display-inline-images
2023-12-03 23:20 [BUG] Hard lockup on org-display-inline-images JD Smith
@ 2023-12-05 12:26 ` Ihor Radchenko
2023-12-05 12:40 ` JD Smith
0 siblings, 1 reply; 4+ messages in thread
From: Ihor Radchenko @ 2023-12-05 12:26 UTC (permalink / raw)
To: JD Smith; +Cc: emacs-orgmode
JD Smith <jdtsmith@gmail.com> writes:
> Eli and I recently patched a problem <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67533> with pixel position reporting with inline images (which I had discovered in a large org buffer with latex-preview). With this patch installed, now on master as of this evening, org-display-inline-images freezes emacs when a larger image is included in an org file, if org-indent is enabled.
>
> I’ve confirmed such images are fine in regular buffers by text-property or overlay, so I suspect this is a “revealed bug” in org-indent or the element cache.
I just tried to create a simple Org file with a png image link (on
main, latest Emacs master), enabled org-indent-mode, and displayed the
images. I see no problem.
Please provide more detailed instructions to reproduce the problem.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] Hard lockup on org-display-inline-images
2023-12-05 12:26 ` Ihor Radchenko
@ 2023-12-05 12:40 ` JD Smith
2023-12-05 12:45 ` Ihor Radchenko
0 siblings, 1 reply; 4+ messages in thread
From: JD Smith @ 2023-12-05 12:40 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]
> On Dec 5, 2023, at 7:26 AM, Ihor Radchenko <yantar92@posteo.net> wrote:
>
> JD Smith <jdtsmith@gmail.com> writes:
>
>> Eli and I recently patched a problem <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67533> with pixel position reporting with inline images (which I had discovered in a large org buffer with latex-preview). With this patch installed, now on master as of this evening, org-display-inline-images freezes emacs when a larger image is included in an org file, if org-indent is enabled.
>>
>> I’ve confirmed such images are fine in regular buffers by text-property or overlay, so I suspect this is a “revealed bug” in org-indent or the element cache.
>
> I just tried to create a simple Org file with a png image link (on
> main, latest Emacs master), enabled org-indent-mode, and displayed the
> images. I see no problem.
>
> Please provide more detailed instructions to reproduce the problem.
Apologies for not following up. The problem was in recent display code improvements. Eli fixed the introduced bug quite quickly in:
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=7a7d41e07c4627c5de08a66368309b478c88edfc
[-- Attachment #2.1: Type: text/html, Size: 4450 bytes --]
[-- Attachment #2.2: favicon.ico --]
[-- Type: image/vnd.microsoft.icon, Size: 3290 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-05 12:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-03 23:20 [BUG] Hard lockup on org-display-inline-images JD Smith
2023-12-05 12:26 ` Ihor Radchenko
2023-12-05 12:40 ` JD Smith
2023-12-05 12:45 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).