emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: JD Smith <jdtsmith@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Hard lockup on org-display-inline-images
Date: Tue, 5 Dec 2023 07:40:43 -0500	[thread overview]
Message-ID: <7079D415-F348-45C8-980E-57904BDFFD95@gmail.com> (raw)
In-Reply-To: <87msuox2bi.fsf@localhost>

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]



> On Dec 5, 2023, at 7:26 AM, Ihor Radchenko <yantar92@posteo.net> wrote:
> 
> JD Smith <jdtsmith@gmail.com> writes:
> 
>> Eli and I recently patched a problem <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67533> with pixel position reporting with inline images (which I had discovered in a large org buffer with latex-preview).  With this patch installed, now on master as of this evening, org-display-inline-images freezes emacs when a larger image is included in an org file, if org-indent is enabled. 
>> 
>> I’ve confirmed such images are fine in regular buffers by text-property or overlay, so I suspect this is a “revealed bug” in org-indent or the element cache.
> 
> I just tried to create a simple Org file with a png image link (on
> main, latest Emacs master), enabled org-indent-mode, and displayed the
> images. I see no problem.
> 
> Please provide more detailed instructions to reproduce the problem.


Apologies for not following up.  The problem was in recent display code improvements.  Eli fixed the introduced bug quite quickly in:

http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=7a7d41e07c4627c5de08a66368309b478c88edfc[-- Attachment #2.1: Type: text/html, Size: 4450 bytes --]

[-- Attachment #2.2: favicon.ico --]
[-- Type: image/vnd.microsoft.icon, Size: 3290 bytes --]

  reply	other threads:[~2023-12-05 12:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-03 23:20 [BUG] Hard lockup on org-display-inline-images JD Smith
2023-12-05 12:26 ` Ihor Radchenko
2023-12-05 12:40   ` JD Smith [this message]
2023-12-05 12:45     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7079D415-F348-45C8-980E-57904BDFFD95@gmail.com \
    --to=jdtsmith@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).