emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nick Dokos <nicholas.dokos@hp.com>
To: Phil Rooke <phil@yax.org.uk>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: Unable to clock in on task
Date: Tue, 27 Oct 2009 10:36:48 -0400	[thread overview]
Message-ID: <3949.1256654208@gamaville.dokosmarshall.org> (raw)
In-Reply-To: Message from Phil Rooke <phil@yax.org.uk> of "Tue, 27 Oct 2009 09:59:27 -0000." <m2skd5non4.fsf@bo.yax.org.uk>

Phil Rooke <phil@yax.org.uk> wrote:

> Keith Lancaster <klancaster1957@acm.org> writes:
> 
> > I updated to 6.32 this morning and am now unable to clock in on
> > tasks. ...
> 
> I too upgraded this morning and am also having problems clocking in
> (using "I" on a task in the daily agenda).  My symptoms are different,
> Emacs doesn't crash but I do consistently get the following:
> 
> Debugger entered--Lisp error: (wrong-type-argument stringp 126)
>   expand-file-name(126)
>   mapcar(expand-file-name "~/Documents/Org/org-agenda-files")
>   org-files-list()
>   org-resolve-clocks()
>   byte-code....
>   org-clock-in(nil)
>   org-agenda-clock-in(nil)
>   call-interactively(org-agenda-clock-in nil nil)
> 

This does look like a bug: org-resolve-clock calls org-files-list which
does not know about the "agenda files list in a file" convention.  It
should probably call the function org-agenda-files instead of
org-files-list. org-files-list is only used in this one place and should
probably be deleted.

Try this patch:

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index ea23a8d..2ce2f22 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -737,7 +737,7 @@ non-dangling (i.e., currently open and valid) clocks."
   (interactive "P")
   (unless org-clock-resolving-clocks
     (let ((org-clock-resolving-clocks t))
-      (dolist (file (org-files-list))
+      (dolist (file (org-agenda-files))
 	(let ((clocks (org-find-open-clocks file)))
 	  (dolist (clock clocks)
 	    (let ((dangling (or (not (org-clock-is-active))

Thanks,
Nick

next prev parent reply	other threads:[~2009-10-27 14:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-26 19:32 Unable to clock in on task Keith Lancaster
2009-10-26 20:35 ` Nick Dokos
2009-10-26 21:56   ` Bernt Hansen
2009-10-27  9:59 ` Phil Rooke
2009-10-27 14:36   ` Nick Dokos [this message]
2009-10-27 14:48     ` Keith Lancaster
2009-10-27 15:06       ` Nick Dokos
     [not found]         ` <31980590-35DC-4887-8E5F-CCE8938AB1AD@acm.org>
2009-10-27 15:28           ` Keith Lancaster
2009-10-27 15:53         ` Phil Rooke
2009-10-27 15:06     ` Phil Rooke
2009-10-27 15:26     ` Carsten Dominik

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:ea23a8d dfblob:2ce2f22
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3949.1256654208@gamaville.dokosmarshall.org \
    --to=nicholas.dokos@hp.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=phil@yax.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).