emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Keith Lancaster <klancaster1957@acm.org>
To: nicholas.dokos@hp.com
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: Unable to clock in on task
Date: Tue, 27 Oct 2009 09:48:35 -0500	[thread overview]
Message-ID: <2FA5AF81-C2CA-4318-AA04-FF734ACC5B76@acm.org> (raw)
In-Reply-To: <3949.1256654208@gamaville.dokosmarshall.org>

That did it! The patch fixes the problem - it now handles all the  
dangling clocks and then clocks in correctly. Thanks!

Keith

On Oct 27, 2009, at 9:36 AM, Nick Dokos wrote:

> Phil Rooke <phil@yax.org.uk> wrote:
>
>> Keith Lancaster <klancaster1957@acm.org> writes:
>>
>>> I updated to 6.32 this morning and am now unable to clock in on
>>> tasks. ...
>>
>> I too upgraded this morning and am also having problems clocking in
>> (using "I" on a task in the daily agenda).  My symptoms are  
>> different,
>> Emacs doesn't crash but I do consistently get the following:
>>
>> Debugger entered--Lisp error: (wrong-type-argument stringp 126)
>>  expand-file-name(126)
>>  mapcar(expand-file-name "~/Documents/Org/org-agenda-files")
>>  org-files-list()
>>  org-resolve-clocks()
>>  byte-code....
>>  org-clock-in(nil)
>>  org-agenda-clock-in(nil)
>>  call-interactively(org-agenda-clock-in nil nil)
>>
>
> This does look like a bug: org-resolve-clock calls org-files-list  
> which
> does not know about the "agenda files list in a file" convention.  It
> should probably call the function org-agenda-files instead of
> org-files-list. org-files-list is only used in this one place and  
> should
> probably be deleted.
>
> Try this patch:
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index ea23a8d..2ce2f22 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -737,7 +737,7 @@ non-dangling (i.e., currently open and valid)  
> clocks."
>   (interactive "P")
>   (unless org-clock-resolving-clocks
>     (let ((org-clock-resolving-clocks t))
> -      (dolist (file (org-files-list))
> +      (dolist (file (org-agenda-files))
> 	(let ((clocks (org-find-open-clocks file)))
> 	  (dolist (clock clocks)
> 	    (let ((dangling (or (not (org-clock-is-active))
>
> Thanks,
> Nick
>

Keith Lancaster
klancaster1957@acm.org

  reply	other threads:[~2009-10-27 14:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-26 19:32 Unable to clock in on task Keith Lancaster
2009-10-26 20:35 ` Nick Dokos
2009-10-26 21:56   ` Bernt Hansen
2009-10-27  9:59 ` Phil Rooke
2009-10-27 14:36   ` Nick Dokos
2009-10-27 14:48     ` Keith Lancaster [this message]
2009-10-27 15:06       ` Nick Dokos
     [not found]         ` <31980590-35DC-4887-8E5F-CCE8938AB1AD@acm.org>
2009-10-27 15:28           ` Keith Lancaster
2009-10-27 15:53         ` Phil Rooke
2009-10-27 15:06     ` Phil Rooke
2009-10-27 15:26     ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2FA5AF81-C2CA-4318-AA04-FF734ACC5B76@acm.org \
    --to=klancaster1957@acm.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=nicholas.dokos@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).