From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Lancaster <klancaster1957@acm.org>
Subject: Re: Unable to clock in on task
Date: Tue, 27 Oct 2009 09:48:35 -0500
Message-ID: <2FA5AF81-C2CA-4318-AA04-FF734ACC5B76@acm.org>
References: <AA7549D7-6CD8-4AAE-9441-C88257CD2532@acm.org>
	<m2skd5non4.fsf@bo.yax.org.uk>
	<3949.1256654208@gamaville.dokosmarshall.org>
Mime-Version: 1.0 (Apple Message framework v1076)
Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N2nLu-0002Kp-Sq
	for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 10:48:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N2nLp-0002Gg-3N
	for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 10:48:49 -0400
Received: from [199.232.76.173] (port=35169 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N2nLo-0002Gd-UJ
	for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 10:48:44 -0400
Received: from mail-ew0-f228.google.com ([209.85.219.228]:60832)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <klancaster1957@gmail.com>) id 1N2nLo-0001xg-H3
	for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 10:48:44 -0400
Received: by ewy28 with SMTP id 28so249856ewy.42
	for <emacs-orgmode@gnu.org>; Tue, 27 Oct 2009 07:48:43 -0700 (PDT)
In-Reply-To: <3949.1256654208@gamaville.dokosmarshall.org>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: nicholas.dokos@hp.com
Cc: Org Mode List <emacs-orgmode@gnu.org>

That did it! The patch fixes the problem - it now handles all the  
dangling clocks and then clocks in correctly. Thanks!

Keith

On Oct 27, 2009, at 9:36 AM, Nick Dokos wrote:

> Phil Rooke <phil@yax.org.uk> wrote:
>
>> Keith Lancaster <klancaster1957@acm.org> writes:
>>
>>> I updated to 6.32 this morning and am now unable to clock in on
>>> tasks. ...
>>
>> I too upgraded this morning and am also having problems clocking in
>> (using "I" on a task in the daily agenda).  My symptoms are  
>> different,
>> Emacs doesn't crash but I do consistently get the following:
>>
>> Debugger entered--Lisp error: (wrong-type-argument stringp 126)
>>  expand-file-name(126)
>>  mapcar(expand-file-name "~/Documents/Org/org-agenda-files")
>>  org-files-list()
>>  org-resolve-clocks()
>>  byte-code....
>>  org-clock-in(nil)
>>  org-agenda-clock-in(nil)
>>  call-interactively(org-agenda-clock-in nil nil)
>>
>
> This does look like a bug: org-resolve-clock calls org-files-list  
> which
> does not know about the "agenda files list in a file" convention.  It
> should probably call the function org-agenda-files instead of
> org-files-list. org-files-list is only used in this one place and  
> should
> probably be deleted.
>
> Try this patch:
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index ea23a8d..2ce2f22 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -737,7 +737,7 @@ non-dangling (i.e., currently open and valid)  
> clocks."
>   (interactive "P")
>   (unless org-clock-resolving-clocks
>     (let ((org-clock-resolving-clocks t))
> -      (dolist (file (org-files-list))
> +      (dolist (file (org-agenda-files))
> 	(let ((clocks (org-find-open-clocks file)))
> 	  (dolist (clock clocks)
> 	    (let ((dangling (or (not (org-clock-is-active))
>
> Thanks,
> Nick
>

Keith Lancaster
klancaster1957@acm.org