From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Dokos <nicholas.dokos@hp.com>
Subject: Re: Unable to clock in on task
Date: Tue, 27 Oct 2009 10:36:48 -0400
Message-ID: <3949.1256654208@gamaville.dokosmarshall.org>
References: <AA7549D7-6CD8-4AAE-9441-C88257CD2532@acm.org>
	<m2skd5non4.fsf@bo.yax.org.uk>
Reply-To: nicholas.dokos@hp.com
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N2nC5-00069t-U7
	for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 10:38:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N2nC0-00067M-C8
	for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 10:38:40 -0400
Received: from [199.232.76.173] (port=59222 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N2nC0-00067J-41
	for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 10:38:36 -0400
Received: from vms173015pub.verizon.net ([206.46.173.15]:63173)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <nick@gamaville.dokosmarshall.org>)
	id 1N2nBz-0000HN-Mx
	for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 10:38:35 -0400
Received: from gamaville.dokosmarshall.org ([173.76.32.106])
	by vms173015.mailsrvcs.net
	(Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008;
	32bit)) with ESMTPA id <0KS600HM2GKZ9654@vms173015.mailsrvcs.net> for
	emacs-orgmode@gnu.org; Tue, 27 Oct 2009 09:36:41 -0500 (CDT)
In-reply-to: Message from Phil Rooke <phil@yax.org.uk> of
	"Tue, 27 Oct 2009 09:59:27 -0000." <m2skd5non4.fsf@bo.yax.org.uk>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Phil Rooke <phil@yax.org.uk>
Cc: Org Mode List <emacs-orgmode@gnu.org>

Phil Rooke <phil@yax.org.uk> wrote:

> Keith Lancaster <klancaster1957@acm.org> writes:
> 
> > I updated to 6.32 this morning and am now unable to clock in on
> > tasks. ...
> 
> I too upgraded this morning and am also having problems clocking in
> (using "I" on a task in the daily agenda).  My symptoms are different,
> Emacs doesn't crash but I do consistently get the following:
> 
> Debugger entered--Lisp error: (wrong-type-argument stringp 126)
>   expand-file-name(126)
>   mapcar(expand-file-name "~/Documents/Org/org-agenda-files")
>   org-files-list()
>   org-resolve-clocks()
>   byte-code....
>   org-clock-in(nil)
>   org-agenda-clock-in(nil)
>   call-interactively(org-agenda-clock-in nil nil)
> 

This does look like a bug: org-resolve-clock calls org-files-list which
does not know about the "agenda files list in a file" convention.  It
should probably call the function org-agenda-files instead of
org-files-list. org-files-list is only used in this one place and should
probably be deleted.

Try this patch:

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index ea23a8d..2ce2f22 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -737,7 +737,7 @@ non-dangling (i.e., currently open and valid) clocks."
   (interactive "P")
   (unless org-clock-resolving-clocks
     (let ((org-clock-resolving-clocks t))
-      (dolist (file (org-files-list))
+      (dolist (file (org-agenda-files))
 	(let ((clocks (org-find-open-clocks file)))
 	  (dolist (clock clocks)
 	    (let ((dangling (or (not (org-clock-is-active))

Thanks,
Nick