* Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly
@ 2009-09-07 13:16 Andreas Burtzlaff
2009-09-07 13:27 ` Giovanni Ridolfi
2009-09-07 15:59 ` David Maus
0 siblings, 2 replies; 5+ messages in thread
From: Andreas Burtzlaff @ 2009-09-07 13:16 UTC (permalink / raw)
To: emacs-orgmode
The last character in a file is not folded correctly,e.g:
<begin example>
* fold this heading
The following X is the *last character* in the file: X<end example>
yields:
* fold this heading...X
Emacs : GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version 2.14.7)
of 2009-08-21 on fluxx
Package: Org-mode version 6.30trans (release_6.30d.19.g1db9)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly
2009-09-07 13:16 Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly Andreas Burtzlaff
@ 2009-09-07 13:27 ` Giovanni Ridolfi
2009-09-07 15:59 ` David Maus
1 sibling, 0 replies; 5+ messages in thread
From: Giovanni Ridolfi @ 2009-09-07 13:27 UTC (permalink / raw)
To: emacs-orgmode, Andreas Burtzlaff
--- Lun 7/9/09, Andreas Burtzlaff <andy13@gmx.net> ha scritto:
> The last character in a file is not folded correctly,e.g:
>
[...]
> * fold this heading...X
>
> Emacs : GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+
> Version 2.14.7)
> of 2009-08-21 on fluxx
> Package: Org-mode version 6.30trans
> (release_6.30d.19.g1db9)
I can reproduce it also with
Org-mode 6.30e
Giovanni
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly
2009-09-07 13:16 Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly Andreas Burtzlaff
2009-09-07 13:27 ` Giovanni Ridolfi
@ 2009-09-07 15:59 ` David Maus
2009-09-07 20:34 ` [PATCH] " Andreas Burtzlaff
1 sibling, 1 reply; 5+ messages in thread
From: David Maus @ 2009-09-07 15:59 UTC (permalink / raw)
To: emacs-orgmode
According to Carsten this misbehaviour is not Orgmode's fault, but
Outline-Mode's
http://www.mail-archive.com/emacs-orgmode@gnu.org/msg16542.html
and should be reported as a bug in Emacs23 (what I do use, too).
*But*: I didn't file a bugreport for Emacs because I cannot reproduce
this misbehavior outside Orgmode. It's indeed (hide-subtree) that
causes the last char beneath a headline be displayed after the
three-dots-thingy but (hide-subtree) behaves fine when used in 'pure'
outline-mode.
So, I decided not to dig into the issue to make file a bugreport as I
can live with it and am quite occupied at the moment.
Regards,
-- David
--
OpenPGP... 0x316F4BE4670716FD
Jabber.... dmjena@jabber.org
Email..... maus.david@gmail.com
ICQ....... 241051416
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly
2009-09-07 15:59 ` David Maus
@ 2009-09-07 20:34 ` Andreas Burtzlaff
2009-09-07 22:39 ` Bastien
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Burtzlaff @ 2009-09-07 20:34 UTC (permalink / raw)
To: emacs-orgmode
On Mon, 07 Sep 2009 17:59:14 +0200
David Maus <maus.david@gmail.com> wrote:
>
> According to Carsten this misbehaviour is not Orgmode's fault, but
> Outline-Mode's
>
> http://www.mail-archive.com/emacs-orgmode@gnu.org/msg16542.html
>
> and should be reported as a bug in Emacs23 (what I do use, too).
>
> *But*: I didn't file a bugreport for Emacs because I cannot reproduce
> this misbehavior outside Orgmode. It's indeed (hide-subtree) that
> causes the last char beneath a headline be displayed after the
> three-dots-thingy but (hide-subtree) behaves fine when used in 'pure'
> outline-mode.
It was indeed org-modes rewrite of outline-end-of-subtree that
triggered the misbehaviour.
Here's the patch:
--8<---------------cut here---------------start------------->8---
diff --git a/lisp/org.el b/lisp/org.el
index 74d7f78..c75f1b9 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -16880,7 +16880,7 @@ If there is no such heading, return nil."
(if (eq major-mode 'org-mode)
(progn
(org-end-of-subtree nil t)
- (backward-char 1))
+ (if (not (eobp)) (backward-char 1)))
ad-do-it))
(defun org-forward-same-level (arg &optional invisible-ok)
--8<---------------cut here---------------end--------------->8---
Andreas
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly
2009-09-07 20:34 ` [PATCH] " Andreas Burtzlaff
@ 2009-09-07 22:39 ` Bastien
0 siblings, 0 replies; 5+ messages in thread
From: Bastien @ 2009-09-07 22:39 UTC (permalink / raw)
To: Andreas Burtzlaff; +Cc: emacs-orgmode
Applied, thanks.
Andreas Burtzlaff <andy13@gmx.net> writes:
> It was indeed org-modes rewrite of outline-end-of-subtree that
> triggered the misbehaviour.
>
> Here's the patch:
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 74d7f78..c75f1b9 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -16880,7 +16880,7 @@ If there is no such heading, return nil."
> (if (eq major-mode 'org-mode)
> (progn
> (org-end-of-subtree nil t)
> - (backward-char 1))
> + (if (not (eobp)) (backward-char 1)))
> ad-do-it))
>
> (defun org-forward-same-level (arg &optional invisible-ok)
>
> Andreas
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
--
Bastien
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-09-08 4:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-07 13:16 Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly Andreas Burtzlaff
2009-09-07 13:27 ` Giovanni Ridolfi
2009-09-07 15:59 ` David Maus
2009-09-07 20:34 ` [PATCH] " Andreas Burtzlaff
2009-09-07 22:39 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).