From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Burtzlaff Subject: Re: [PATCH] Org-mode version 6.30trans (release_6.30d.19.g1db9); Last character in file not folded correctly Date: Mon, 7 Sep 2009 22:34:39 +0200 Message-ID: <20090907223439.ab06e893.andy13@gmx.net> References: <20090907151606.9e372fcf.andy13@gmx.net> <87r5uisq3x.wl%maus.david@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MkkvB-0002Iv-AX for emacs-orgmode@gnu.org; Mon, 07 Sep 2009 16:34:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mkkv6-0002Bm-H8 for emacs-orgmode@gnu.org; Mon, 07 Sep 2009 16:34:40 -0400 Received: from [199.232.76.173] (port=47957 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mkkv6-0002BI-BA for emacs-orgmode@gnu.org; Mon, 07 Sep 2009 16:34:36 -0400 Received: from mail.gmx.net ([213.165.64.20]:35384) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Mkkv5-0000fY-NJ for emacs-orgmode@gnu.org; Mon, 07 Sep 2009 16:34:36 -0400 In-Reply-To: <87r5uisq3x.wl%maus.david@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org On Mon, 07 Sep 2009 17:59:14 +0200 David Maus wrote: > > According to Carsten this misbehaviour is not Orgmode's fault, but > Outline-Mode's > > http://www.mail-archive.com/emacs-orgmode@gnu.org/msg16542.html > > and should be reported as a bug in Emacs23 (what I do use, too). > > *But*: I didn't file a bugreport for Emacs because I cannot reproduce > this misbehavior outside Orgmode. It's indeed (hide-subtree) that > causes the last char beneath a headline be displayed after the > three-dots-thingy but (hide-subtree) behaves fine when used in 'pure' > outline-mode. It was indeed org-modes rewrite of outline-end-of-subtree that triggered the misbehaviour. Here's the patch: --8<---------------cut here---------------start------------->8--- diff --git a/lisp/org.el b/lisp/org.el index 74d7f78..c75f1b9 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -16880,7 +16880,7 @@ If there is no such heading, return nil." (if (eq major-mode 'org-mode) (progn (org-end-of-subtree nil t) - (backward-char 1)) + (if (not (eobp)) (backward-char 1))) ad-do-it)) (defun org-forward-same-level (arg &optional invisible-ok) --8<---------------cut here---------------end--------------->8--- Andreas