* [BUG] ob-shell async incorrect table and value results
@ 2024-03-06 20:51 Matt
2024-03-08 9:28 ` Ihor Radchenko
0 siblings, 1 reply; 3+ messages in thread
From: Matt @ 2024-03-06 20:51 UTC (permalink / raw)
To: emacs-orgmode
#+name: sync table
#+begin_src sh :session *test* :results table
echo "hello world"
#+end_src
#+RESULTS:
| hello world |
#+name: async table
#+begin_src sh :session *test* :results table :async t
echo "hello world"
#+end_src
#+RESULTS:
: hello world
#+name: sync value
#+begin_src sh :session *test* :results value
echo "hello world"
#+end_src
#+RESULTS:
: 0
#+name: async value
#+begin_src sh :session *test* :results value :async t
echo "hello world"
#+end_src
#+RESULTS:
: hello world
: 0
--
Matt Trzcinski
Emacs Org contributor (ob-shell)
Learn more about Org mode at https://orgmode.org
Support Org development at https://liberapay.com/org-mode
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG] ob-shell async incorrect table and value results
2024-03-06 20:51 [BUG] ob-shell async incorrect table and value results Matt
@ 2024-03-08 9:28 ` Ihor Radchenko
2024-03-09 7:08 ` Matt
0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2024-03-08 9:28 UTC (permalink / raw)
To: Matt; +Cc: emacs-orgmode
Matt <matt@excalamus.com> writes:
> #+name: sync table
> #+begin_src sh :session *test* :results table
> echo "hello world"
> #+end_src
>
> #+RESULTS:
> | hello world |
>
> #+name: async table
> #+begin_src sh :session *test* :results table :async t
> echo "hello world"
> #+end_src
>
> #+RESULTS:
> : hello world
Confirmed.
This is because `ob-shell-async-chunk-callback' never returns a list.
In `org-babel-sh-evaluate', there is a part that is responsible for
detecting the result type:
(when (and results value-is-exit-status)
(setq results (car (reverse (split-string results "\n" t)))))
(when results
(let ((result-params (cdr (assq :result-params params))))
(org-babel-result-cond result-params
results
(let ((tmp-file (org-babel-temp-file "sh-")))
(with-temp-file tmp-file (insert results))
(org-babel-import-elisp-from-file tmp-file)))))
This part is skipped for :async results.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [BUG] ob-shell async incorrect table and value results
2024-03-08 9:28 ` Ihor Radchenko
@ 2024-03-09 7:08 ` Matt
0 siblings, 0 replies; 3+ messages in thread
From: Matt @ 2024-03-09 7:08 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
---- On Fri, 08 Mar 2024 10:25:09 +0100 Ihor Radchenko wrote ---
> Confirmed.
> This is because `ob-shell-async-chunk-callback' never returns a list.
>
> In `org-babel-sh-evaluate', there is a part that is responsible for
> detecting the result type:
>
> (when (and results value-is-exit-status)
> (setq results (car (reverse (split-string results "\n" t)))))
> (when results
> (let ((result-params (cdr (assq :result-params params))))
> (org-babel-result-cond result-params
> results
> (let ((tmp-file (org-babel-temp-file "sh-")))
> (with-temp-file tmp-file (insert results))
> (org-babel-import-elisp-from-file tmp-file)))))
>
> This part is skipped for :async results.
Thanks for looking at it. I'm still working on "[BUG] Prompt appears in async shell results" (https://list.orgmode.org/18dbc1f273c.11687295c1395973.3345700621594100711@excalamus.com/T/#u) and will circle back to this when that's done.
--
Matt Trzcinski
Emacs Org contributor (ob-shell)
Learn more about Org mode at https://orgmode.org
Support Org development at https://liberapay.com/org-mode
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-09 7:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-06 20:51 [BUG] ob-shell async incorrect table and value results Matt
2024-03-08 9:28 ` Ihor Radchenko
2024-03-09 7:08 ` Matt
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).