From: Matt <matt@excalamus.com>
To: "Ihor Radchenko" <yantar92@posteo.net>
Cc: "emacs-orgmode" <emacs-orgmode@gnu.org>
Subject: Re: [BUG] ob-shell async incorrect table and value results
Date: Sat, 09 Mar 2024 08:08:28 +0100 [thread overview]
Message-ID: <18e220aad9d.ddd6245f2410492.1077254202219187330@excalamus.com> (raw)
In-Reply-To: <87zfv9hy2h.fsf@localhost>
---- On Fri, 08 Mar 2024 10:25:09 +0100 Ihor Radchenko wrote ---
> Confirmed.
> This is because `ob-shell-async-chunk-callback' never returns a list.
>
> In `org-babel-sh-evaluate', there is a part that is responsible for
> detecting the result type:
>
> (when (and results value-is-exit-status)
> (setq results (car (reverse (split-string results "\n" t)))))
> (when results
> (let ((result-params (cdr (assq :result-params params))))
> (org-babel-result-cond result-params
> results
> (let ((tmp-file (org-babel-temp-file "sh-")))
> (with-temp-file tmp-file (insert results))
> (org-babel-import-elisp-from-file tmp-file)))))
>
> This part is skipped for :async results.
Thanks for looking at it. I'm still working on "[BUG] Prompt appears in async shell results" (https://list.orgmode.org/18dbc1f273c.11687295c1395973.3345700621594100711@excalamus.com/T/#u) and will circle back to this when that's done.
--
Matt Trzcinski
Emacs Org contributor (ob-shell)
Learn more about Org mode at https://orgmode.org
Support Org development at https://liberapay.com/org-mode
prev parent reply other threads:[~2024-03-09 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 20:51 [BUG] ob-shell async incorrect table and value results Matt
2024-03-08 9:28 ` Ihor Radchenko
2024-03-09 7:08 ` Matt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18e220aad9d.ddd6245f2410492.1077254202219187330@excalamus.com \
--to=matt@excalamus.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).