From: Nick Dokos <nicholas.dokos@hp.com>
To: Bastien <bzg@gnu.org>
Cc: Bernt Hansen <bernt@norang.ca>,
emacs-orgmode@gnu.org, Eric Schulte <eric.schulte@gmx.com>
Subject: Re: Tangling is broken in git master
Date: Mon, 13 Aug 2012 11:38:43 -0400 [thread overview]
Message-ID: <11277.1344872323@alphaville> (raw)
In-Reply-To: Message from Bastien <bzg@gnu.org> of "Mon, 13 Aug 2012 16:53:59 +0200." <87pq6ux2pk.fsf@gnu.org>
Bastien <bzg@gnu.org> wrote:
> Hi Nick,
>
> Nick Dokos <nicholas.dokos@hp.com> writes:
>
> > Can't the definition of letrec in emacs24 be lifted bodily into org-compat.el
> > (or whatever the correct place is) as a compatibility-with-emacs-23 macro?
>
> I don't think it's worth the effort.
>
> The current code works and compiles without warnings for the user.
>
What about future code? IME, it's always worthwhile to be thinking about
ways to avoid future bugs.
> Getting rid of org-flet was to make things a bit more "elispy",
> but I'm fine with `org-labels' and those four lines of warnings-
> for-developers-only.
>
It's more the freedom that it gives to developers (i.e Eric S. :-) ) who
are used to writing code a certain way: the way it is now, they've got
to keep in mind that letrec is not valid for emacs23 and write the code
differently - I'd suggest that that can be a source of bugs that would be
avoided with a compatibility macro.
But maybe the compatibility macro would be a bigger problem - I don't
know for sure. In particular, the file would need a periodic cleanup to
get rid of old cruft, but if it's a once-a-year-or-two occurrence, that
might not be too bad.
Nick
next prev parent reply other threads:[~2012-08-13 15:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-12 1:03 Tangling is broken in git master Bernt Hansen
2012-08-12 6:27 ` Achim Gratz
2012-08-13 1:57 ` Bernt Hansen
2012-08-12 8:43 ` Bastien
2012-08-13 1:55 ` Bernt Hansen
2012-08-13 5:43 ` Bastien
2012-08-13 13:44 ` Eric Schulte
2012-08-13 13:56 ` Bastien
2012-08-13 14:18 ` Eric Schulte
2012-08-13 14:42 ` Bastien
2012-08-13 15:25 ` Nicolas Goaziou
2012-08-13 19:00 ` Bastien
2012-08-13 14:46 ` Nick Dokos
2012-08-13 14:53 ` Bastien
2012-08-13 15:38 ` Nick Dokos [this message]
2012-08-13 19:00 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11277.1344872323@alphaville \
--to=nicholas.dokos@hp.com \
--cc=bernt@norang.ca \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=eric.schulte@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).