emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Eric Schulte <eric.schulte@gmx.com>
To: Bastien <bzg@gnu.org>
Cc: Bernt Hansen <bernt@norang.ca>, emacs-orgmode@gnu.org
Subject: Re: Tangling is broken in git master
Date: Mon, 13 Aug 2012 08:18:48 -0600	[thread overview]
Message-ID: <87obmeg9il.fsf@gmx.com> (raw)
In-Reply-To: <87r4rayjxu.fsf@gnu.org> (Bastien's message of "Mon, 13 Aug 2012 15:56:29 +0200")

Bastien <bzg@gnu.org> writes:

> Hi Eric,
>
> Eric Schulte <eric.schulte@gmx.com> writes:
>
>> I've just pushed up another version of this commit, which I believe
>> removes cl-labels while still preserving tangling behavior.  If you have
>> a chance please re-check tangling with the latest Org-mode.
>
> `letrec' is not available on Emacs <24.1 
>
> Your commit looks like the one I pushed here...
> http://orgmode.org/w/?p=org-mode.git;a=commit;h=ba16c3
>
> ... and reverted, thanks to Bernt's report.
>
> Apart from one replacement of org-labels with `let*' in ob.el,
> I don't see how we can get rid of `org-labels' completely.

Oh, my apologies, I just reverted my commit.  I thought letrec was an
old elisp construct.  I'm happy to stick with using org-labels (the code
was much more readable using org-labels).

I'm surprised that elisp doesn't provide any mechanism for local
anonymous functions.  I can't imagine why this would be an intentional
design decision.

Thanks,

-- 
Eric Schulte
http://cs.unm.edu/~eschulte

next prev parent reply	other threads:[~2012-08-13 14:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-12  1:03 Tangling is broken in git master Bernt Hansen
2012-08-12  6:27 ` Achim Gratz
2012-08-13  1:57   ` Bernt Hansen
2012-08-12  8:43 ` Bastien
2012-08-13  1:55   ` Bernt Hansen
2012-08-13  5:43     ` Bastien
2012-08-13 13:44       ` Eric Schulte
2012-08-13 13:56         ` Bastien
2012-08-13 14:18           ` Eric Schulte [this message]
2012-08-13 14:42             ` Bastien
2012-08-13 15:25               ` Nicolas Goaziou
2012-08-13 19:00                 ` Bastien
2012-08-13 14:46             ` Nick Dokos
2012-08-13 14:53               ` Bastien
2012-08-13 15:38                 ` Nick Dokos
2012-08-13 19:00                   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obmeg9il.fsf@gmx.com \
    --to=eric.schulte@gmx.com \
    --cc=bernt@norang.ca \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).